Re: [PATCH] ACPI: boot correctly with "nosmp" or "maxcpus=0"

[Andi Kleen <ak@suse.de>]

On Friday 17 August 2007 01:06:47 Len Brown wrote:
> On Thursday 16 August 2007 15:36, Andi Kleen wrote:
> > > @@ -157,10 +162,13 @@ early_param("nosmp", nosmp);
> > >  static int __init maxcpus(char *str)
> > >  {
> > >  	get_option(&str, &max_cpus);
> > > -	return 1;
> > > +	if (max_cpus == 0)
> > > +		disable_ioapic_setup();
> > 
> > I must say I never liked that maxcpus=0 ... does disable the APIC
> > too. There can be situations where you want only a single CPU,
> > but still full APICs because modern systems don't boot without. 
> 
> maxcpus=1 will give you that.
> new kernel-parameters.txt in patch should say this
> (matching what comment in the code says)

Ok.

> The only reason I fixed it instead of changing it per above
> is because people may be used to it in non ACPI configurations
> and get surprised when it doesn't do exactly the same
> thing (or in this case doesn't boot at all) in an ACPI configuration.

Patch is fine for me.

-Andi