All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Joe Perches <joe@perches.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Whitcroft <apw@shadowen.org>
Subject: Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow
Date: Sun, 19 Aug 2007 22:44:25 +0000	[thread overview]
Message-ID: <20070819224425.GU21089@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0708200031560.19577@fbirervta.pbzchgretzou.qr>

On Mon, Aug 20, 2007 at 12:33:21AM +0200, Jan Engelhardt wrote:
> 
> On Aug 19 2007 15:17, Joe Perches wrote:
> >There are several files that:
> >
> >#include "linux/file" not #include <linux/file>
> >#include "asm/file" not #include <asm/file>
> 
> Not only that. All directories in include should be checked against
> (e.g. <net/*>)

Except that some instances are legitimate (e.g. there was a bunch in
arch/um, IIRC)...

WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ftp.linux.org.uk>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Joe Perches <joe@perches.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Whitcroft <apw@shadowen.org>
Subject: Re: convert #include "linux/..." to #include <linux/...> [PATCH]s follow
Date: Sun, 19 Aug 2007 23:44:25 +0100	[thread overview]
Message-ID: <20070819224425.GU21089@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0708200031560.19577@fbirervta.pbzchgretzou.qr>

On Mon, Aug 20, 2007 at 12:33:21AM +0200, Jan Engelhardt wrote:
> 
> On Aug 19 2007 15:17, Joe Perches wrote:
> >There are several files that:
> >
> >#include "linux/file" not #include <linux/file>
> >#include "asm/file" not #include <asm/file>
> 
> Not only that. All directories in include should be checked against
> (e.g. <net/*>)

Except that some instances are legitimate (e.g. there was a bunch in
arch/um, IIRC)...

  reply	other threads:[~2007-08-19 22:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-19 22:17 convert #include "linux/..." to #include <linux/...> [PATCH]s Joe Perches
2007-08-19 22:17 ` convert #include "linux/..." to #include <linux/...> [PATCH]s follow Joe Perches
2007-08-19 22:19 ` Jesper Juhl
2007-08-19 22:19   ` Jesper Juhl
2007-08-19 22:33 ` convert #include "linux/..." to #include <linux/...> [PATCH]s Jan Engelhardt
2007-08-19 22:33   ` convert #include "linux/..." to #include <linux/...> [PATCH]s follow Jan Engelhardt
2007-08-19 22:44   ` Al Viro [this message]
2007-08-19 22:44     ` Al Viro
2007-08-19 22:49     ` convert #include "linux/..." to #include <linux/...> [PATCH]s Joe Perches
2007-08-19 22:49       ` convert #include "linux/..." to #include <linux/...> [PATCH]s follow Joe Perches
2007-08-19 22:58       ` Al Viro
2007-08-19 22:58         ` Al Viro
2007-08-19 23:05   ` convert #include "linux/..." to #include <linux/...> [PATCH]s Joe Perches
2007-08-19 23:05     ` convert #include "linux/..." to #include <linux/...> [PATCH]s follow Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070819224425.GU21089@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=apw@shadowen.org \
    --cc=jengelh@computergmbh.de \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.