All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Dike <jdike@addtoit.com>
To: Blaisorblade <blaisorblade@yahoo.it>
Cc: Miklos Szeredi <mszeredi@suse.cz>,
	Maxim Krasnyansky <maxk@qualcomm.com>,
	Jeff Dike <jdike@karaya.com>,
	kernel-janitors@vger.kernel.org, Jason Lunz <lunz@falooley.org>,
	Jan Beulich <jbeulich@novell.com>, Andi Kleen <ak@suse.de>,
	vtun@office.satix.net, Jens Axboe <jens.axboe@oracle.com>,
	Stephen Hemminger <shemminger@linux-foundation.org>,
	Nick Piggin <npiggin@suse.de>,
	Davide Brini <davide.brini@unibo.it>,
	Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>,
	virtualization@lists.osdl.org, Ingo Molnar <mingo@elte.hu>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Zachary Amsden <zach@vmware.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	user-mode-linux-devel@lists.sourceforge.net,
	Jeff Dike <jdike@addtoit.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Eduard-Gabriel Munteanu <maxdamage@aladin.ro>,
	Chris Wright <chrisw@sous-sol.org>,
	user-mode-linux-user@lists.sourceforge.net,
	Jeff Dike <jdike@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Jeremy Fitzhardinge <jeremy@xensource.com>,
	Haavard Skinnemoen <hskinnemoen@atmel.com>,
	linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
	Kyle McMartin <kyle@mcmartin.ca>, Ollie Wild <aaw@google.com>,
	Joe Perches <joe@perches.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [uml-devel] [PATCH 1/5] um/... convert #include "linux/..." to #include	<linux/...>
Date: Wed, 22 Aug 2007 12:25:08 -0400	[thread overview]
Message-ID: <20070822162508.GA11022@c2.user-mode-linux.org> (raw)
In-Reply-To: <200708211909.23027.blaisorblade@yahoo.it>

On Tue, Aug 21, 2007 at 07:09:17PM +0200, Blaisorblade wrote:
> Wait, this patch may or may not be sane (Jeff will tell more I guess).

It's sane.

> Since 
> we use two different sets of headers (the host ones from userspace and the 
> guest ones from Linux), this peculiar style has been used till now to make 
> clear the difference (#include <file> is used for host headers) - at least 
> that's what I think (I've never asked to Jeff, but I silently deduced this 
> and followed this practice).

Yeah, and it makes some sense to extend the practice to the kernel
side, where <> is used for generic headers and "" for UML-specific
ones.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Dike <jdike@addtoit.com>
To: Blaisorblade <blaisorblade@yahoo.it>
Cc: Miklos Szeredi <mszeredi@suse.cz>,
	Maxim Krasnyansky <maxk@qualcomm.com>,
	Jeff Dike <jdike@karaya.com>,
	kernel-janitors@vger.kernel.org, Jason Lunz <lunz@falooley.org>,
	Jan Beulich <jbeulich@novell.com>,
	vtun@office.satix.net, Jens Axboe <jens.axboe@oracle.com>,
	Stephen Hemminger <shemminger@linux-foundation.org>,
	Nick Piggin <npiggin@suse.de>,
	Davide Brini <davide.brini@unibo.it>,
	Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>,
	virtualization@lists.osdl.org, Ingo Molnar <mingo@elte.hu>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	user-mode-linux-devel@lists.sourceforge.net,
	Jeff Dike <jdike@addtoit.com>,
	Eduard-Gabriel Munteanu <maxdamage@aladin.ro>,
	Chris Wright <chrisw@sous-sol.org>,
	user-mode-linux-user@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH 1/5] um/... convert #include "linux/..." to #include	<linux/...>
Date: Wed, 22 Aug 2007 12:25:08 -0400	[thread overview]
Message-ID: <20070822162508.GA11022@c2.user-mode-linux.org> (raw)
In-Reply-To: <200708211909.23027.blaisorblade@yahoo.it>

On Tue, Aug 21, 2007 at 07:09:17PM +0200, Blaisorblade wrote:
> Wait, this patch may or may not be sane (Jeff will tell more I guess).

It's sane.

> Since 
> we use two different sets of headers (the host ones from userspace and the 
> guest ones from Linux), this peculiar style has been used till now to make 
> clear the difference (#include <file> is used for host headers) - at least 
> that's what I think (I've never asked to Jeff, but I silently deduced this 
> and followed this practice).

Yeah, and it makes some sense to extend the practice to the kernel
side, where <> is used for generic headers and "" for UML-specific
ones.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

  reply	other threads:[~2007-08-22 16:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-19 22:18 [uml-devel] [PATCH 1/5] um/... convert #include "linux/..." to #include <linux/...> Joe Perches
2007-08-19 22:18 ` Joe Perches
2007-08-21 17:09 ` [uml-devel] " Blaisorblade
2007-08-21 17:09   ` Blaisorblade
2007-08-22 16:25   ` Jeff Dike [this message]
2007-08-22 16:25     ` Jeff Dike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070822162508.GA11022@c2.user-mode-linux.org \
    --to=jdike@addtoit.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=aaw@google.com \
    --cc=acme@redhat.com \
    --cc=adobriyan@gmail.com \
    --cc=ak@suse.de \
    --cc=blaisorblade@yahoo.it \
    --cc=chrisw@sous-sol.org \
    --cc=davem@davemloft.net \
    --cc=davide.brini@unibo.it \
    --cc=fernando@oss.ntt.co.jp \
    --cc=hskinnemoen@atmel.com \
    --cc=jbeulich@novell.com \
    --cc=jdike@karaya.com \
    --cc=jdike@linux.intel.com \
    --cc=jens.axboe@oracle.com \
    --cc=jeremy@xensource.com \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kyle@mcmartin.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lunz@falooley.org \
    --cc=maxdamage@aladin.ro \
    --cc=maxk@qualcomm.com \
    --cc=mingo@elte.hu \
    --cc=mszeredi@suse.cz \
    --cc=npiggin@suse.de \
    --cc=ralf@linux-mips.org \
    --cc=rusty@rustcorp.com.au \
    --cc=shemminger@linux-foundation.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    --cc=user-mode-linux-user@lists.sourceforge.net \
    --cc=virtualization@lists.osdl.org \
    --cc=vtun@office.satix.net \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.