[uml-devel] UML doesn't build in 2.6.23-rc3.

[uml-devel] UML doesn't build in 2.6.23-rc3.

[Rob Landley]

I fixed it for me with the following patch, just in case anybody else had this 
problem:

--- linux-2.6.23-rc3/arch/um/kernel/smp.c	2007-08-12 23:25:24.000000000 -0500
+++ linux-2.6.23-new/arch/um/kernel/smp.c	2007-08-21 21:39:00.000000000 -0500
@@ -5,6 +5,7 @@
 
 #include "linux/percpu.h"
 #include "asm/pgalloc.h"
+#include "linux/pagemap.h"
 #include "asm/tlb.h"
 
 /* For some reason, mmu_gathers are referenced when CONFIG_SMP is off. */

-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] UML doesn't build in 2.6.23-rc3.

[Jeff Dike]

On Tue, Aug 21, 2007 at 09:48:05PM -0500, Rob Landley wrote:
> I fixed it for me with the following patch, just in case anybody
> else had this problem:

What were the errors?

		Jeff

-- 
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] UML doesn't build in 2.6.23-rc3.

[Rob Landley]

On Wednesday 22 August 2007 12:24:56 pm Jeff Dike wrote:
> On Tue, Aug 21, 2007 at 09:48:05PM -0500, Rob Landley wrote:
> > I fixed it for me with the following patch, just in case anybody
> > else had this problem:
>
> What were the errors?
>
> 		Jeff

  CC      arch/um/os-Linux/file.o
In file included from include/asm/arch/tlb.h:18,
                 from include/asm/tlb.h:4,
                 from arch/um/kernel/smp.c:8:
include/asm-generic/tlb.h: In function ‘tlb_flush_mmu’:
include/asm-generic/tlb.h:76: error: implicit declaration of 
function ‘release_pages’
include/asm-generic/tlb.h: In function ‘tlb_remove_page’:
include/asm-generic/tlb.h:105: error: implicit declaration of 
function ‘page_cache_release’
make[1]: *** [arch/um/kernel/smp.o] Error 1
make: *** [arch/um/kernel] Error 2
make: *** Waiting for unfinished jobs....

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] UML doesn't build in 2.6.23-rc3.

[Jeff Dike]

On Wed, Aug 22, 2007 at 04:26:53PM -0500, Rob Landley wrote:
> include/asm-generic/tlb.h: In function ‘tlb_flush_mmu’:
> include/asm-generic/tlb.h:76: error: implicit declaration of 
> function ‘release_pages’
> include/asm-generic/tlb.h: In function ‘tlb_remove_page’:
> include/asm-generic/tlb.h:105: error: implicit declaration of 
> function ‘page_cache_release’

Shouldn't the new include go in asm-generic/tlb.h instead?

Index: linux-2.6.22/include/asm-generic/tlb.h
===================================================================
--- linux-2.6.22.orig/include/asm-generic/tlb.h	2007-07-08 19:32:17.000000000 -0400
+++ linux-2.6.22/include/asm-generic/tlb.h	2007-08-22 17:29:45.000000000 -0400
@@ -13,6 +13,7 @@
 #ifndef _ASM_GENERIC__TLB_H
 #define _ASM_GENERIC__TLB_H
 
+#include <linux/pagemap.h>
 #include <linux/swap.h>
 #include <asm/pgalloc.h>
 #include <asm/tlbflush.h>

This doesn't cause any obvious problems, but then I wasn't seeing the
build failure in the first place.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] UML doesn't build in 2.6.23-rc3.

[Rob Landley]

On Wednesday 22 August 2007 4:31:15 pm Jeff Dike wrote:
> On Wed, Aug 22, 2007 at 04:26:53PM -0500, Rob Landley wrote:
> > include/asm-generic/tlb.h: In function ‘tlb_flush_mmu’:
> > include/asm-generic/tlb.h:76: error: implicit declaration of
> > function ‘release_pages’
> > include/asm-generic/tlb.h: In function ‘tlb_remove_page’:
> > include/asm-generic/tlb.h:105: error: implicit declaration of
> > function ‘page_cache_release’
>
> Shouldn't the new include go in asm-generic/tlb.h instead?

I didn't say it was the right fix, just that it got it to work for me. :)

> This doesn't cause any obvious problems, but then I wasn't seeing the
> build failure in the first place.

cat > mini.conf << EOF
CONFIG_MODE_SKAS=y
CONFIG_BINFMT_ELF=y
CONFIG_HOSTFS=y
CONFIG_SYSCTL=y
CONFIG_STDERR_CONSOLE=y
CONFIG_UNIX98_PTYS=y
CONFIG_BLK_DEV_LOOP=y
CONFIG_LBD=y
CONFIG_EXT2_FS=y
CONFIG_PROC_FS=y
EOF
make ARCH=um allnoconfig KCONFIG_ALLCONFIG=mini.conf
make ARCH=um

Does that reproduce it for you?

> 				Jeff

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] UML doesn't build in 2.6.23-rc3.

[Jeff Dike]

On Wed, Aug 22, 2007 at 08:47:01PM -0500, Rob Landley wrote:
> Does that reproduce it for you?

Yup, but it's somewhat non-obvious why.  Anyway, it seems clear that
asm-generic/tlb.h is missing an include.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] UML doesn't build in 2.6.23-rc3.

[Rob Landley]

On Wednesday 22 August 2007 10:44:13 pm Jeff Dike wrote:
> On Wed, Aug 22, 2007 at 08:47:01PM -0500, Rob Landley wrote:
> > Does that reproduce it for you?
>
> Yup, but it's somewhat non-obvious why.  Anyway, it seems clear that
> asm-generic/tlb.h is missing an include.
>
> 				Jeff

I still need the patch I posted to build -rc5.  Just FYI.

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel