* [patch 1/1] fix a trivial typo in scripts/checkstack.pl [not found] <20070823125227.294913273@finow14.de> @ 2007-08-23 12:55 ` andre 2007-08-23 13:13 ` Jörn Engel 2007-08-23 13:26 ` Adrian Bunk 0 siblings, 2 replies; 7+ messages in thread From: andre @ 2007-08-23 12:55 UTC (permalink / raw) To: joern; +Cc: linux-kernel, Andre Haupt [-- Attachment #1: fix_trivial_typo_in_checkstack.pl --] [-- Type: text/plain, Size: 543 bytes --] Signed-off-by: Andre Haupt <andre@finow14.de> --- Index: linus/scripts/checkstack.pl =================================================================== --- linus.orig/scripts/checkstack.pl 2007-08-23 14:25:03.000000000 +0200 +++ linus/scripts/checkstack.pl 2007-08-23 14:42:13.000000000 +0200 @@ -14,7 +14,7 @@ # M68k port by Geert Uytterhoeven and Andreas Schwab # # Usage: -# objdump -d vmlinux | stackcheck.pl [arch] +# objdump -d vmlinux | scripts/checkstack.pl [arch] # # TODO : Port to all architectures (one regex per arch) -- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch 1/1] fix a trivial typo in scripts/checkstack.pl 2007-08-23 12:55 ` [patch 1/1] fix a trivial typo in scripts/checkstack.pl andre @ 2007-08-23 13:13 ` Jörn Engel 2007-08-23 21:11 ` Andrew Morton 2007-08-23 13:26 ` Adrian Bunk 1 sibling, 1 reply; 7+ messages in thread From: Jörn Engel @ 2007-08-23 13:13 UTC (permalink / raw) To: Andrew Morton; +Cc: andre, joern, linux-kernel Trivial change in a comment. Signed-off-by: Jörn Engel <joern@logfs.org> Signed-off-by: Andre Haupt <andre@finow14.de> --- Index: linus/scripts/checkstack.pl =================================================================== --- linus.orig/scripts/checkstack.pl 2007-08-23 14:25:03.000000000 +0200 +++ linus/scripts/checkstack.pl 2007-08-23 14:42:13.000000000 +0200 @@ -14,7 +14,7 @@ # M68k port by Geert Uytterhoeven and Andreas Schwab # # Usage: -# objdump -d vmlinux | stackcheck.pl [arch] +# objdump -d vmlinux | scripts/checkstack.pl [arch] # # TODO : Port to all architectures (one regex per arch) Jörn -- Correctness comes second. Features come third. Performance comes last. Maintainability is easily forgotten. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch 1/1] fix a trivial typo in scripts/checkstack.pl 2007-08-23 13:13 ` Jörn Engel @ 2007-08-23 21:11 ` Andrew Morton 2007-08-23 22:27 ` Randy Dunlap 0 siblings, 1 reply; 7+ messages in thread From: Andrew Morton @ 2007-08-23 21:11 UTC (permalink / raw) To: Jörn Engel; +Cc: andre, linux-kernel, Andy Whitcroft On Thu, 23 Aug 2007 15:13:02 +0200 Jörn Engel <joern@logfs.org> wrote: > Trivial change in a comment. > > Signed-off-by: Jörn Engel <joern@logfs.org> > Signed-off-by: Andre Haupt <andre@finow14.de> > --- > Index: linus/scripts/checkstack.pl > =================================================================== > --- linus.orig/scripts/checkstack.pl 2007-08-23 14:25:03.000000000 +0200 > +++ linus/scripts/checkstack.pl 2007-08-23 14:42:13.000000000 +0200 > @@ -14,7 +14,7 @@ > # M68k port by Geert Uytterhoeven and Andreas Schwab > # > # Usage: > -# objdump -d vmlinux | stackcheck.pl [arch] > +# objdump -d vmlinux | scripts/checkstack.pl [arch] > # > # TODO : Port to all architectures (one regex per arch) Thanks, I forwarded this to Andy. I prefer not to apply checkpatch patches directly to -mm as it's still under a considerable amount of development and anything which I apply would just get tangled up with Andy's next update. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch 1/1] fix a trivial typo in scripts/checkstack.pl 2007-08-23 21:11 ` Andrew Morton @ 2007-08-23 22:27 ` Randy Dunlap 0 siblings, 0 replies; 7+ messages in thread From: Randy Dunlap @ 2007-08-23 22:27 UTC (permalink / raw) To: Andrew Morton; +Cc: Jörn Engel, andre, linux-kernel, Andy Whitcroft On Thu, 23 Aug 2007 14:11:16 -0700 Andrew Morton wrote: > On Thu, 23 Aug 2007 15:13:02 +0200 > Jörn Engel <joern@logfs.org> wrote: > > > Trivial change in a comment. > > > > Signed-off-by: Jörn Engel <joern@logfs.org> > > Signed-off-by: Andre Haupt <andre@finow14.de> > > --- > > Index: linus/scripts/checkstack.pl > > =================================================================== > > --- linus.orig/scripts/checkstack.pl 2007-08-23 14:25:03.000000000 +0200 > > +++ linus/scripts/checkstack.pl 2007-08-23 14:42:13.000000000 +0200 > > @@ -14,7 +14,7 @@ > > # M68k port by Geert Uytterhoeven and Andreas Schwab > > # > > # Usage: > > -# objdump -d vmlinux | stackcheck.pl [arch] > > +# objdump -d vmlinux | scripts/checkstack.pl [arch] > > # > > # TODO : Port to all architectures (one regex per arch) > > Thanks, I forwarded this to Andy. I prefer not to apply checkpatch > patches directly to -mm as it's still under a considerable amount of > development and anything which I apply would just get tangled up with > Andy's next update. That's checkstack, not checkpatch... The patch is correct, but most people use it (checkstack) via make checkstack AFAIK. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch 1/1] fix a trivial typo in scripts/checkstack.pl 2007-08-23 12:55 ` [patch 1/1] fix a trivial typo in scripts/checkstack.pl andre 2007-08-23 13:13 ` Jörn Engel @ 2007-08-23 13:26 ` Adrian Bunk 2007-08-23 13:35 ` Jörn Engel 1 sibling, 1 reply; 7+ messages in thread From: Adrian Bunk @ 2007-08-23 13:26 UTC (permalink / raw) To: joern, linux-kernel, Andre Haupt On Thu, Aug 23, 2007 at 02:55:40PM +0200, andre@finow14.de wrote: > Signed-off-by: Andre Haupt <andre@finow14.de> > --- > Index: linus/scripts/checkstack.pl > =================================================================== > --- linus.orig/scripts/checkstack.pl 2007-08-23 14:25:03.000000000 +0200 > +++ linus/scripts/checkstack.pl 2007-08-23 14:42:13.000000000 +0200 > @@ -14,7 +14,7 @@ > # M68k port by Geert Uytterhoeven and Andreas Schwab > # > # Usage: > -# objdump -d vmlinux | stackcheck.pl [arch] > +# objdump -d vmlinux | scripts/checkstack.pl [arch] >... "make checkstack" ? cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch 1/1] fix a trivial typo in scripts/checkstack.pl 2007-08-23 13:26 ` Adrian Bunk @ 2007-08-23 13:35 ` Jörn Engel 2007-08-23 16:06 ` Randy Dunlap 0 siblings, 1 reply; 7+ messages in thread From: Jörn Engel @ 2007-08-23 13:35 UTC (permalink / raw) To: Adrian Bunk; +Cc: joern, linux-kernel, Andre Haupt On Thu, 23 August 2007 15:26:39 +0200, Adrian Bunk wrote: > On Thu, Aug 23, 2007 at 02:55:40PM +0200, andre@finow14.de wrote: > > Signed-off-by: Andre Haupt <andre@finow14.de> > > --- > > Index: linus/scripts/checkstack.pl > > =================================================================== > > --- linus.orig/scripts/checkstack.pl 2007-08-23 14:25:03.000000000 +0200 > > +++ linus/scripts/checkstack.pl 2007-08-23 14:42:13.000000000 +0200 > > @@ -14,7 +14,7 @@ > > # M68k port by Geert Uytterhoeven and Andreas Schwab > > # > > # Usage: > > -# objdump -d vmlinux | stackcheck.pl [arch] > > +# objdump -d vmlinux | scripts/checkstack.pl [arch] > >... > > "make checkstack" ? If you really care about this, send a patch. An argument against it is that some people seem to use the script independently of the linux kernel. Not sure if all of them copy the makefile logic as well. Does it matter? Jörn -- Anything that can go wrong, will. -- Finagle's Law ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch 1/1] fix a trivial typo in scripts/checkstack.pl 2007-08-23 13:35 ` Jörn Engel @ 2007-08-23 16:06 ` Randy Dunlap 0 siblings, 0 replies; 7+ messages in thread From: Randy Dunlap @ 2007-08-23 16:06 UTC (permalink / raw) To: Jörn Engel; +Cc: Adrian Bunk, joern, linux-kernel, Andre Haupt On Thu, 23 Aug 2007 15:35:29 +0200 Jörn Engel wrote: > On Thu, 23 August 2007 15:26:39 +0200, Adrian Bunk wrote: > > On Thu, Aug 23, 2007 at 02:55:40PM +0200, andre@finow14.de wrote: > > > Signed-off-by: Andre Haupt <andre@finow14.de> > > > --- > > > Index: linus/scripts/checkstack.pl > > > =================================================================== > > > --- linus.orig/scripts/checkstack.pl 2007-08-23 14:25:03.000000000 +0200 > > > +++ linus/scripts/checkstack.pl 2007-08-23 14:42:13.000000000 +0200 > > > @@ -14,7 +14,7 @@ > > > # M68k port by Geert Uytterhoeven and Andreas Schwab > > > # > > > # Usage: > > > -# objdump -d vmlinux | stackcheck.pl [arch] > > > +# objdump -d vmlinux | scripts/checkstack.pl [arch] > > >... > > > > "make checkstack" ? Yes, "make help" already lists this and the other check* scripts. > If you really care about this, send a patch. An argument against it is > that some people seem to use the script independently of the linux > kernel. Not sure if all of them copy the makefile logic as well. > > Does it matter? --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-08-23 22:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20070823125227.294913273@finow14.de>
2007-08-23 12:55 ` [patch 1/1] fix a trivial typo in scripts/checkstack.pl andre
2007-08-23 13:13 ` Jörn Engel
2007-08-23 21:11 ` Andrew Morton
2007-08-23 22:27 ` Randy Dunlap
2007-08-23 13:26 ` Adrian Bunk
2007-08-23 13:35 ` Jörn Engel
2007-08-23 16:06 ` Randy Dunlap
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.