All of lore.kernel.org
 help / color / mirror / Atom feed
From: travis@sgi.com
To: Andi Kleen <ak@suse.de>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <clameter@sgi.com>
Subject: [PATCH 1/6] x86: fix cpu_to_node references (v2)
Date: Fri, 24 Aug 2007 15:26:55 -0700	[thread overview]
Message-ID: <20070824222948.587159000@sgi.com> (raw)
In-Reply-To: 20070824222654.687510000@sgi.com

[-- Attachment #1: fix-cpu_to_node-refs --]
[-- Type: text/plain, Size: 1698 bytes --]

Fix four instances where cpu_to_node is referenced
by array instead of via the cpu_to_node macro.  This
is preparation to moving it to the per_cpu data area.

Signed-off-by: Mike Travis <travis@sgi.com>
---
 arch/x86_64/kernel/vsyscall.c |    2 +-
 arch/x86_64/mm/numa.c         |    4 ++--
 arch/x86_64/mm/srat.c         |    4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

--- a/arch/x86_64/kernel/vsyscall.c
+++ b/arch/x86_64/kernel/vsyscall.c
@@ -283,7 +283,7 @@
 	unsigned long *d;
 	unsigned long node = 0;
 #ifdef CONFIG_NUMA
-	node = cpu_to_node[cpu];
+	node = cpu_to_node(cpu);
 #endif
 	if (cpu_has(&cpu_data[cpu], X86_FEATURE_RDTSCP))
 		write_rdtscp_aux((node << 12) | cpu);
--- a/arch/x86_64/mm/numa.c
+++ b/arch/x86_64/mm/numa.c
@@ -264,7 +264,7 @@
 	   We round robin the existing nodes. */
 	rr = first_node(node_online_map);
 	for (i = 0; i < NR_CPUS; i++) {
-		if (cpu_to_node[i] != NUMA_NO_NODE)
+		if (cpu_to_node(i) != NUMA_NO_NODE)
 			continue;
  		numa_set_node(i, rr);
 		rr = next_node(rr, node_online_map);
@@ -546,7 +546,7 @@
 void __cpuinit numa_set_node(int cpu, int node)
 {
 	cpu_pda(cpu)->nodenumber = node;
-	cpu_to_node[cpu] = node;
+	cpu_to_node(cpu) = node;
 }
 
 unsigned long __init numa_free_all_bootmem(void) 
--- a/arch/x86_64/mm/srat.c
+++ b/arch/x86_64/mm/srat.c
@@ -431,9 +431,9 @@
 			setup_node_bootmem(i, nodes[i].start, nodes[i].end);
 
 	for (i = 0; i < NR_CPUS; i++) {
-		if (cpu_to_node[i] == NUMA_NO_NODE)
+		if (cpu_to_node(i) == NUMA_NO_NODE)
 			continue;
-		if (!node_isset(cpu_to_node[i], node_possible_map))
+		if (!node_isset(cpu_to_node(i), node_possible_map))
 			numa_set_node(i, NUMA_NO_NODE);
 	}
 	numa_init_array();

-- 

WARNING: multiple messages have this Message-ID (diff)
From: travis@sgi.com
To: Andi Kleen <ak@suse.de>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <clameter@sgi.com>
Subject: [PATCH 1/6] x86: fix cpu_to_node references (v2)
Date: Fri, 24 Aug 2007 15:26:55 -0700	[thread overview]
Message-ID: <20070824222948.587159000@sgi.com> (raw)
In-Reply-To: 20070824222654.687510000@sgi.com

[-- Attachment #1: fix-cpu_to_node-refs --]
[-- Type: text/plain, Size: 1924 bytes --]

Fix four instances where cpu_to_node is referenced
by array instead of via the cpu_to_node macro.  This
is preparation to moving it to the per_cpu data area.

Signed-off-by: Mike Travis <travis@sgi.com>
---
 arch/x86_64/kernel/vsyscall.c |    2 +-
 arch/x86_64/mm/numa.c         |    4 ++--
 arch/x86_64/mm/srat.c         |    4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

--- a/arch/x86_64/kernel/vsyscall.c
+++ b/arch/x86_64/kernel/vsyscall.c
@@ -283,7 +283,7 @@
 	unsigned long *d;
 	unsigned long node = 0;
 #ifdef CONFIG_NUMA
-	node = cpu_to_node[cpu];
+	node = cpu_to_node(cpu);
 #endif
 	if (cpu_has(&cpu_data[cpu], X86_FEATURE_RDTSCP))
 		write_rdtscp_aux((node << 12) | cpu);
--- a/arch/x86_64/mm/numa.c
+++ b/arch/x86_64/mm/numa.c
@@ -264,7 +264,7 @@
 	   We round robin the existing nodes. */
 	rr = first_node(node_online_map);
 	for (i = 0; i < NR_CPUS; i++) {
-		if (cpu_to_node[i] != NUMA_NO_NODE)
+		if (cpu_to_node(i) != NUMA_NO_NODE)
 			continue;
  		numa_set_node(i, rr);
 		rr = next_node(rr, node_online_map);
@@ -546,7 +546,7 @@
 void __cpuinit numa_set_node(int cpu, int node)
 {
 	cpu_pda(cpu)->nodenumber = node;
-	cpu_to_node[cpu] = node;
+	cpu_to_node(cpu) = node;
 }
 
 unsigned long __init numa_free_all_bootmem(void) 
--- a/arch/x86_64/mm/srat.c
+++ b/arch/x86_64/mm/srat.c
@@ -431,9 +431,9 @@
 			setup_node_bootmem(i, nodes[i].start, nodes[i].end);
 
 	for (i = 0; i < NR_CPUS; i++) {
-		if (cpu_to_node[i] == NUMA_NO_NODE)
+		if (cpu_to_node(i) == NUMA_NO_NODE)
 			continue;
-		if (!node_isset(cpu_to_node[i], node_possible_map))
+		if (!node_isset(cpu_to_node(i), node_possible_map))
 			numa_set_node(i, NUMA_NO_NODE);
 	}
 	numa_init_array();

-- 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-08-24 22:29 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-24 22:26 [PATCH 0/6] x86: Reduce Memory Usage and Inter-Node message traffic (v2) travis
2007-08-24 22:26 ` travis
2007-08-24 22:26 ` travis [this message]
2007-08-24 22:26   ` [PATCH 1/6] x86: fix cpu_to_node references (v2) travis
2007-08-25  0:23   ` Siddha, Suresh B
2007-08-25  0:23     ` Siddha, Suresh B
2007-08-27 19:47     ` Mike Travis
2007-08-27 19:47       ` Mike Travis
2007-08-24 22:26 ` [PATCH 2/6] x86: Convert cpu_core_map to be a per cpu variable (v2) travis
2007-08-24 22:26   ` travis
2007-08-24 22:26 ` [PATCH 3/6] x86: Convert cpu_sibling_map " travis
2007-08-24 22:26   ` travis
2007-09-01  2:49   ` Andrew Morton
2007-09-01  2:49     ` Andrew Morton
2007-09-01 11:34     ` Kamalesh Babulal
2007-09-01 11:34       ` Kamalesh Babulal
2007-09-01 16:10       ` Andrew Morton
2007-09-01 16:10         ` Andrew Morton
2007-09-02 11:48         ` Kamalesh Babulal
2007-09-02 11:48           ` Kamalesh Babulal
2007-09-01 14:06     ` Andi Kleen
2007-09-01 14:06       ` Andi Kleen
2007-08-24 22:26 ` [PATCH 4/6] x86: Convert x86_cpu_to_apicid " travis
2007-08-24 22:26   ` travis
2007-08-24 22:26 ` [PATCH 5/6] x86: Convert cpu_llc_id " travis
2007-08-24 22:26   ` travis
2007-08-24 22:27 ` [PATCH 6/6] x86: acpi-use-cpu_physical_id (v2) travis
2007-08-24 22:27   ` travis
2007-08-25  0:50 ` [PATCH 0/6] x86: Reduce Memory Usage and Inter-Node message traffic (v2) Siddha, Suresh B
2007-08-25  0:50   ` Siddha, Suresh B
2007-08-25  9:24   ` Andi Kleen
2007-08-25  9:24     ` Andi Kleen
2007-08-25 16:52     ` Randy Dunlap
2007-08-25 16:52       ` Randy Dunlap
2007-08-27 18:46     ` Mike Travis
2007-08-27 18:46       ` Mike Travis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070824222948.587159000@sgi.com \
    --to=travis@sgi.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.