From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [patch 0/6] Per cpu structures for SLUB
Date: Mon, 27 Aug 2007 16:51:26 -0700 [thread overview]
Message-ID: <20070827165126.a1a9846b.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0708271144440.4667@schroedinger.engr.sgi.com>
On Mon, 27 Aug 2007 11:50:10 -0700 (PDT)
Christoph Lameter <clameter@sgi.com> wrote:
> On Fri, 24 Aug 2007, Andrew Morton wrote:
>
> > I'm struggling a bit to understand these numbers. Bigger is better, I
> > assume? In what units are these numbers?
>
> No less is better. These are cycle counts. Hmmm... We discussed these
> cycle counts so much in the last week that I forgot to mention that.
>
> > > Page allocator pass through
> > > ---------------------------
> > > There is a significant difference in the columns marked with a * because
> > > of the way that allocations for page sized objects are handled.
> >
> > OK, but what happened to the third pair of columns (Concurrent Alloc,
> > Kmalloc) for 1024 and 2048-byte allocations? They seem to have become
> > significantly slower?
>
> There is a significant performance increase there. That is the main point
> of the patch.
>
> > Thanks for running the numbers, but it's still a bit hard to work out
> > whether these changes are an aggregate benefit?
>
> There is a drawback because of the additional code introduced in the fast
> path. However, the regular kmalloc case shows improvements throughout.
> This is in particular of importance for SMP systems. We see an improvement
> even for 2 processors.
umm, OK. When you have time, could you please whizz up a clearer
changelog for this one?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [patch 0/6] Per cpu structures for SLUB
Date: Mon, 27 Aug 2007 16:51:26 -0700 [thread overview]
Message-ID: <20070827165126.a1a9846b.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0708271144440.4667@schroedinger.engr.sgi.com>
On Mon, 27 Aug 2007 11:50:10 -0700 (PDT)
Christoph Lameter <clameter@sgi.com> wrote:
> On Fri, 24 Aug 2007, Andrew Morton wrote:
>
> > I'm struggling a bit to understand these numbers. Bigger is better, I
> > assume? In what units are these numbers?
>
> No less is better. These are cycle counts. Hmmm... We discussed these
> cycle counts so much in the last week that I forgot to mention that.
>
> > > Page allocator pass through
> > > ---------------------------
> > > There is a significant difference in the columns marked with a * because
> > > of the way that allocations for page sized objects are handled.
> >
> > OK, but what happened to the third pair of columns (Concurrent Alloc,
> > Kmalloc) for 1024 and 2048-byte allocations? They seem to have become
> > significantly slower?
>
> There is a significant performance increase there. That is the main point
> of the patch.
>
> > Thanks for running the numbers, but it's still a bit hard to work out
> > whether these changes are an aggregate benefit?
>
> There is a drawback because of the additional code introduced in the fast
> path. However, the regular kmalloc case shows improvements throughout.
> This is in particular of importance for SMP systems. We see an improvement
> even for 2 processors.
umm, OK. When you have time, could you please whizz up a clearer
changelog for this one?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-08-27 23:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 6:46 [patch 0/6] Per cpu structures for SLUB Christoph Lameter
2007-08-23 6:46 ` Christoph Lameter
2007-08-23 6:46 ` [patch 1/6] SLUB: Avoid page struct cacheline bouncing due to remote frees to cpu slab Christoph Lameter
2007-08-23 6:46 ` Christoph Lameter
2007-08-23 6:46 ` [patch 2/6] SLUB: Do not use page->mapping Christoph Lameter
2007-08-23 6:46 ` Christoph Lameter
2007-08-23 6:46 ` [patch 3/6] SLUB: Move page->offset to kmem_cache_cpu->offset Christoph Lameter
2007-08-23 6:46 ` Christoph Lameter
2007-08-23 6:46 ` [patch 4/6] SLUB: Avoid touching page struct when freeing to per cpu slab Christoph Lameter
2007-08-23 6:46 ` Christoph Lameter
2007-08-23 15:05 ` Peter Zijlstra
2007-08-23 19:30 ` Christoph Lameter
2007-08-24 16:46 ` Christoph Lameter
2007-08-23 6:46 ` [patch 5/6] SLUB: Place kmem_cache_cpu structures in a NUMA aware way Christoph Lameter
2007-08-23 6:46 ` Christoph Lameter
2007-08-23 6:46 ` [patch 6/6] SLUB: Optimize cacheline use for zeroing Christoph Lameter
2007-08-23 6:46 ` Christoph Lameter
2007-08-23 9:52 ` [patch 0/6] Per cpu structures for SLUB Peter Zijlstra
2007-08-23 19:25 ` Christoph Lameter
2007-08-24 21:38 ` Andrew Morton
2007-08-24 21:38 ` Andrew Morton
2007-08-27 18:50 ` Christoph Lameter
2007-08-27 18:50 ` Christoph Lameter
2007-08-27 23:51 ` Andrew Morton [this message]
2007-08-27 23:51 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070827165126.a1a9846b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.