* Re: [Cbe-oss-dev] [patch 1/5] spu_manage: use newer physical-id [not found] <20070823.180152.-1300528381.kouish@swc.toshiba.co.jp> @ 2007-08-23 16:12 ` Arnd Bergmann 0 siblings, 0 replies; 6+ messages in thread From: Arnd Bergmann @ 2007-08-23 16:12 UTC (permalink / raw) To: kou.ishizaki; +Cc: linuxppc-dev, paulus, linux-kernel, cbe-oss-dev, jk On Thursday 23 August 2007, kou.ishizaki@toshiba.co.jp wrote: > Please check "unit-id" if "physical-id" doesn't exist. Because Celleb > uses "unit-id" to provide spe_id. Ok, I need to discuss this with Christian then, to make sure we get to a version that works everywhere. Paul, please ignore this patch for now. I've update the git repository to only have the other four patches. Arnd <>< ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Cbe-oss-dev] [patch 1/5] spu_manage: use newer physical-id @ 2007-08-23 16:12 ` Arnd Bergmann 0 siblings, 0 replies; 6+ messages in thread From: Arnd Bergmann @ 2007-08-23 16:12 UTC (permalink / raw) To: kou.ishizaki; +Cc: paulus, linux-kernel, linuxppc-dev, jk, cbe-oss-dev On Thursday 23 August 2007, kou.ishizaki@toshiba.co.jp wrote: > Please check "unit-id" if "physical-id" doesn't exist. Because Celleb > uses "unit-id" to provide spe_id. Ok, I need to discuss this with Christian then, to make sure we get to a version that works everywhere. Paul, please ignore this patch for now. I've update the git repository to only have the other four patches. Arnd <>< ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Cbe-oss-dev] [patch 1/5] spu_manage: use newer physical-id 2007-08-23 16:12 ` Arnd Bergmann @ 2007-08-28 14:20 ` Christian Krafft -1 siblings, 0 replies; 6+ messages in thread From: Christian Krafft @ 2007-08-28 14:20 UTC (permalink / raw) To: Arnd Bergmann; +Cc: linux-kernel, linuxppc-dev, jk, krafft, cbe-oss-dev On Thu, 23 Aug 2007 18:12:19 +0200 Arnd Bergmann <arnd@arndb.de> wrote: > On Thursday 23 August 2007, kou.ishizaki@toshiba.co.jp wrote: > > Please check "unit-id" if "physical-id" doesn't exist. Because Celleb > > uses "unit-id" to provide spe_id. Sorry for the late answer, wasn't on cc and had to receive all mails of the last 6 month once again :-( Can you check if the patch below is working with celleb device tree ? ------ Subject: spu_manage: fix spu_unit_number for celleb device tree From: Christian Krafft <krafft@de.ibm.com> New device trees provide "physical-id". Celleb device tree provide the "unit-id". Legacy device tree used the reg property for the physical id of an spe. This patch fixes find_spu_unit_number to look for the spu id in that order. The length is checked to avoid misinterpretation in case the attributes unit-id or reg do not contain the id. Signed-off-by: Christian Krafft <krafft@de.ibm.com> Index: linux/arch/powerpc/platforms/cell/spu_manage.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- linux.orig/arch/powerpc/platforms/cell/spu_manage.c +++ linux/arch/powerpc/platforms/cell/spu_manage.c @@ -48,10 +48,18 @@ static u64 __init find_spu_unit_number(s { const unsigned int *prop; int proplen; + + /* new device trees should provide the physical-id attribute */ prop =3D of_get_property(spe, "physical-id", &proplen); if (proplen =3D=3D 4) return (u64)*prop; =20 + /* celleb device tree provides the unit-id */ + prop =3D of_get_property(spe, "unit-id", &proplen); + if (proplen =3D=3D 4) + return (u64)*prop; + + /* legacy device trees provide the id in the reg attribute */ prop =3D of_get_property(spe, "reg", &proplen); if (proplen =3D=3D 4) return (u64)*prop; --=20 Mit freundlichen Gr=FCssen, kind regards, Christian Krafft IBM Systems & Technology Group,=20 Linux Kernel Development IT Specialist ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Cbe-oss-dev] [patch 1/5] spu_manage: use newer physical-id @ 2007-08-28 14:20 ` Christian Krafft 0 siblings, 0 replies; 6+ messages in thread From: Christian Krafft @ 2007-08-28 14:20 UTC (permalink / raw) To: Arnd Bergmann Cc: kou.ishizaki, linuxppc-dev, linux-kernel, cbe-oss-dev, jk, krafft On Thu, 23 Aug 2007 18:12:19 +0200 Arnd Bergmann <arnd@arndb.de> wrote: > On Thursday 23 August 2007, kou.ishizaki@toshiba.co.jp wrote: > > Please check "unit-id" if "physical-id" doesn't exist. Because Celleb > > uses "unit-id" to provide spe_id. Sorry for the late answer, wasn't on cc and had to receive all mails of the last 6 month once again :-( Can you check if the patch below is working with celleb device tree ? ------ Subject: spu_manage: fix spu_unit_number for celleb device tree From: Christian Krafft <krafft@de.ibm.com> New device trees provide "physical-id". Celleb device tree provide the "unit-id". Legacy device tree used the reg property for the physical id of an spe. This patch fixes find_spu_unit_number to look for the spu id in that order. The length is checked to avoid misinterpretation in case the attributes unit-id or reg do not contain the id. Signed-off-by: Christian Krafft <krafft@de.ibm.com> Index: linux/arch/powerpc/platforms/cell/spu_manage.c =================================================================== --- linux.orig/arch/powerpc/platforms/cell/spu_manage.c +++ linux/arch/powerpc/platforms/cell/spu_manage.c @@ -48,10 +48,18 @@ static u64 __init find_spu_unit_number(s { const unsigned int *prop; int proplen; + + /* new device trees should provide the physical-id attribute */ prop = of_get_property(spe, "physical-id", &proplen); if (proplen == 4) return (u64)*prop; + /* celleb device tree provides the unit-id */ + prop = of_get_property(spe, "unit-id", &proplen); + if (proplen == 4) + return (u64)*prop; + + /* legacy device trees provide the id in the reg attribute */ prop = of_get_property(spe, "reg", &proplen); if (proplen == 4) return (u64)*prop; -- Mit freundlichen Grüssen, kind regards, Christian Krafft IBM Systems & Technology Group, Linux Kernel Development IT Specialist ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Cbe-oss-dev] [patch 1/5] spu_manage: use newer physical-id 2007-08-28 14:20 ` Christian Krafft @ 2007-08-29 8:56 ` Ishizaki Kou -1 siblings, 0 replies; 6+ messages in thread From: Ishizaki Kou @ 2007-08-29 8:56 UTC (permalink / raw) To: krafft; +Cc: linuxppc-dev, cbe-oss-dev, linux-kernel, arnd, jk Christian Krafft wrote: > On Thu, 23 Aug 2007 18:12:19 +0200 > Arnd Bergmann <arnd@arndb.de> wrote: > > > On Thursday 23 August 2007, kou.ishizaki@toshiba.co.jp wrote: > > > Please check "unit-id" if "physical-id" doesn't exist. Because Celleb > > > uses "unit-id" to provide spe_id. > > Sorry for the late answer, wasn't on cc > and had to receive all mails of the last 6 month once again :-( > > Can you check if the patch below is working with celleb device tree ? > > ------ > Subject: spu_manage: fix spu_unit_number for celleb device tree > > From: Christian Krafft <krafft@de.ibm.com> > > New device trees provide "physical-id". > Celleb device tree provide the "unit-id". > Legacy device tree used the reg property for the physical id of an spe. > This patch fixes find_spu_unit_number to look for the spu id in that order. > The length is checked to avoid misinterpretation in case the attributes > unit-id or reg do not contain the id. > > Signed-off-by: Christian Krafft <krafft@de.ibm.com> Acked-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp> It works good on Celleb, thanks. Please apply it to 2.6.23. Best regards, Kou Ishizaki ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Cbe-oss-dev] [patch 1/5] spu_manage: use newer physical-id @ 2007-08-29 8:56 ` Ishizaki Kou 0 siblings, 0 replies; 6+ messages in thread From: Ishizaki Kou @ 2007-08-29 8:56 UTC (permalink / raw) To: krafft; +Cc: arnd, linux-kernel, linuxppc-dev, jk, cbe-oss-dev Christian Krafft wrote: > On Thu, 23 Aug 2007 18:12:19 +0200 > Arnd Bergmann <arnd@arndb.de> wrote: > > > On Thursday 23 August 2007, kou.ishizaki@toshiba.co.jp wrote: > > > Please check "unit-id" if "physical-id" doesn't exist. Because Celleb > > > uses "unit-id" to provide spe_id. > > Sorry for the late answer, wasn't on cc > and had to receive all mails of the last 6 month once again :-( > > Can you check if the patch below is working with celleb device tree ? > > ------ > Subject: spu_manage: fix spu_unit_number for celleb device tree > > From: Christian Krafft <krafft@de.ibm.com> > > New device trees provide "physical-id". > Celleb device tree provide the "unit-id". > Legacy device tree used the reg property for the physical id of an spe. > This patch fixes find_spu_unit_number to look for the spu id in that order. > The length is checked to avoid misinterpretation in case the attributes > unit-id or reg do not contain the id. > > Signed-off-by: Christian Krafft <krafft@de.ibm.com> Acked-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp> It works good on Celleb, thanks. Please apply it to 2.6.23. Best regards, Kou Ishizaki ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-08-29 9:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20070823.180152.-1300528381.kouish@swc.toshiba.co.jp>
2007-08-23 16:12 ` [Cbe-oss-dev] [patch 1/5] spu_manage: use newer physical-id Arnd Bergmann
2007-08-23 16:12 ` Arnd Bergmann
2007-08-28 14:20 ` Christian Krafft
2007-08-28 14:20 ` Christian Krafft
2007-08-29 8:56 ` Ishizaki Kou
2007-08-29 8:56 ` Ishizaki Kou
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.