All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	neilb@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add source address to sunrpc svc errors
Date: Tue, 28 Aug 2007 14:56:21 -0400	[thread overview]
Message-ID: <20070828185621.GD3764@fieldses.org> (raw)
In-Reply-To: <20070828180306.GA25233@gallifrey>

On Tue, Aug 28, 2007 at 07:03:06PM +0100, Dr. David Alan Gilbert wrote:
> * J. Bruce Fields (bfields@fieldses.org) wrote:
> > I also wonder whether these shouldn't all be dprintk's instead of
> > printk's.  One misbehaving client could create a lot of noise in the
> > logs.
> 
> Yeh; I wasn't going to change anything else about it;   the
> rate limiting (that I think Neil put in a few months ago) means
> that any one client doesn't get too noisy - I've got something
> trying to do version 0 on nfs to a bunch of boxes and I do wonder
> why; I suspect it's just a monitoring script - but it seems better
> to know about it until I figure it out.

OK.

> I'm not going to be able to recut the patch until the weekend;
> do you just want to remove the 'err' in your copy and feed this
> to the main tree with some of the rest of your patches?

Done; result at

	git://linux-nfs.org/~bfields/linux.git	nfs-server-stable

if you'd like to check.

--b.

  reply	other threads:[~2007-08-28 18:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-25  1:26 [PATCH] Add source address to sunrpc svc errors Dr. David Alan Gilbert
2007-08-25  1:56 ` Randy Dunlap
2007-08-25 15:09   ` Dr. David Alan Gilbert
2007-08-27 21:43     ` J. Bruce Fields
2007-08-28 18:03       ` Dr. David Alan Gilbert
2007-08-28 18:56         ` J. Bruce Fields [this message]
2007-09-01 19:27           ` Dr. David Alan Gilbert
2007-08-28 19:12       ` Valdis.Kletnieks
2007-08-28 19:19         ` J. Bruce Fields
2007-08-29 18:26           ` Valdis.Kletnieks
2007-08-29 13:37         ` Peter Staubach
2007-08-29 13:50           ` J. Bruce Fields
2007-08-29 19:41           ` Valdis.Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070828185621.GD3764@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=neilb@suse.de \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.