All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Staubach <staubach@redhat.com>
To: Valdis.Kletnieks@vt.edu
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	"Dr. David Alan Gilbert" <linux@treblig.org>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	neilb@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add source address to sunrpc svc errors
Date: Wed, 29 Aug 2007 09:37:00 -0400	[thread overview]
Message-ID: <46D5767C.9050206@redhat.com> (raw)
In-Reply-To: <7788.1188328346@turing-police.cc.vt.edu>

Valdis.Kletnieks@vt.edu wrote:
> On Mon, 27 Aug 2007 17:43:33 EDT, "J. Bruce Fields" said:
>
>   
>> Looks like a reasonable idea to me, thanks!  Any objection to just
>> calling it "svc_printk" instead of "svc_printkerr"?
>>
>> I also wonder whether these shouldn't all be dprintk's instead of
>> printk's.  One misbehaving client could create a lot of noise in the
>> logs.
>>     
>
> I shouldn't have to rebuild my kernel with debugging enabled just to see
> who is throwing trash at my machine.  printk(KERN_INFO maybe and/or using
> a printk_ratelimit.
>   

There are a lot of ways to discover who is throwing trash
at your system other than the kernel printing messages.

Tools such as tcpdump and tethereal/wireshark make much better
tools for this purpose.

    Thanx...

       ps

  parent reply	other threads:[~2007-08-29 13:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-25  1:26 [PATCH] Add source address to sunrpc svc errors Dr. David Alan Gilbert
2007-08-25  1:56 ` Randy Dunlap
2007-08-25 15:09   ` Dr. David Alan Gilbert
2007-08-27 21:43     ` J. Bruce Fields
2007-08-28 18:03       ` Dr. David Alan Gilbert
2007-08-28 18:56         ` J. Bruce Fields
2007-09-01 19:27           ` Dr. David Alan Gilbert
2007-08-28 19:12       ` Valdis.Kletnieks
2007-08-28 19:19         ` J. Bruce Fields
2007-08-29 18:26           ` Valdis.Kletnieks
2007-08-29 13:37         ` Peter Staubach [this message]
2007-08-29 13:50           ` J. Bruce Fields
2007-08-29 19:41           ` Valdis.Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46D5767C.9050206@redhat.com \
    --to=staubach@redhat.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=bfields@fieldses.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=neilb@suse.de \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.