Re: [RFC,PATCH 04/20] svc: xpt_has_wspace

["J. Bruce Fields" <bfields@fieldses.org>]

On Mon, Aug 20, 2007 at 11:23:30AM -0500, Tom Tucker wrote:
> -	set_bit(SOCK_NOSPACE, &svsk->sk_sock->flags);
> -	if (((atomic_read(&svsk->sk_reserved) + serv->sv_max_mesg)*2
> -	     > svc_sock_wspace(svsk))
> -	    && !test_bit(SK_CLOSE, &svsk->sk_flags)
> -	    && !test_bit(SK_CONN, &svsk->sk_flags)) {
> -		/* Don't enqueue while not enough space for reply */
> -		dprintk("svc: socket %p  no space, %d*2 > %ld, not enqueued\n",
> -			svsk->sk_sk, atomic_read(&svsk->sk_reserved)+serv->sv_max_mesg,
> -			svc_sock_wspace(svsk));

Actually, I'm confused by the existing code here.  The intention seems
to be to stop accepting requests until we have adequate space for the
reply.  But the (&& !test_bit(SK_CONN, &svsk->sk_flags)) means that the
condition always fails on a socket with SK_CONN set.  From a quick skim
of uses of SK_CONN in svcsock.c it looks SK_CONN is normally set on an
established connection.

I must be missing something obvious.  Or the test is reversed.

--b.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs