From: "John W. Linville" <linville@tuxdriver.com>
To: Nick Kossifidis <mickflemm@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jiri Slaby <jirislaby@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals
Date: Thu, 30 Aug 2007 08:38:49 -0400 [thread overview]
Message-ID: <20070830123849.GB5140@tuxdriver.com> (raw)
In-Reply-To: <40f31dec0708291850j2d35db6cu9de7c5f0a91e76f7@mail.gmail.com>
On Thu, Aug 30, 2007 at 04:50:01AM +0300, Nick Kossifidis wrote:
> 2007/8/28, Christoph Hellwig <hch@infradead.org>:
> > ath5k_hw_phy.o should probably be ath5k_phy.o by conventions used by
> > most drivers and ath5k_hw_inivals.o mights aswell be something like
> > ath5k_init.o
> If you check out the code you'll see i'm using the same convention
> inside them, ath5k_hw* files contain hw related functions
> (ath5k_hw_<name>) while driver code has ath5k_<name>. Also ath5k_init
> is misleading, file acually includes initial register settings for
I have to agree w/ Christoph -- the extra "_hw" in the names is just
a bit unwieldy.
John
P.S. "ath5k_initvals.c" seems acceptable to me.
--
John W. Linville
linville@tuxdriver.com
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: Nick Kossifidis <mickflemm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Jiri Slaby <jirislaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals
Date: Thu, 30 Aug 2007 08:38:49 -0400 [thread overview]
Message-ID: <20070830123849.GB5140@tuxdriver.com> (raw)
In-Reply-To: <40f31dec0708291850j2d35db6cu9de7c5f0a91e76f7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, Aug 30, 2007 at 04:50:01AM +0300, Nick Kossifidis wrote:
> 2007/8/28, Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>:
> > ath5k_hw_phy.o should probably be ath5k_phy.o by conventions used by
> > most drivers and ath5k_hw_inivals.o mights aswell be something like
> > ath5k_init.o
> If you check out the code you'll see i'm using the same convention
> inside them, ath5k_hw* files contain hw related functions
> (ath5k_hw_<name>) while driver code has ath5k_<name>. Also ath5k_init
> is misleading, file acually includes initial register settings for
I have to agree w/ Christoph -- the extra "_hw" in the names is just
a bit unwieldy.
John
P.S. "ath5k_initvals.c" seems acceptable to me.
--
John W. Linville
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org
next prev parent reply other threads:[~2007-08-30 13:15 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-28 15:58 [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals Jiri Slaby
2007-08-28 15:59 ` [PATCH 2/5] Net: ath5k, switch to ioread/iowrite Jiri Slaby
2007-08-28 16:00 ` [PATCH 3/5] Net: ath5k, use int as retval Jiri Slaby
2007-08-30 12:40 ` John W. Linville
2007-08-30 12:40 ` John W. Linville
2007-09-01 20:08 ` Jiri Slaby
2007-09-01 20:08 ` Jiri Slaby
2007-09-02 15:55 ` Nick Kossifidis
2007-09-02 15:55 ` Nick Kossifidis
2007-09-03 6:34 ` Jiri Slaby
2007-09-03 13:37 ` Nick Kossifidis
2007-08-28 16:00 ` [PATCH 4/5] Net: ath5k, license is GPLv2 Jiri Slaby
2007-08-28 17:11 ` Christoph Hellwig
2007-08-28 20:11 ` Luis R. Rodriguez
2007-08-29 17:29 ` Valdis.Kletnieks
2007-08-29 18:01 ` Jon Smirl
2007-08-29 18:28 ` Alan Cox
2007-08-29 19:33 ` Jon Smirl
2007-08-29 19:33 ` Jon Smirl
2007-08-29 19:37 ` Michael Buesch
2007-08-29 19:37 ` Michael Buesch
2007-08-30 8:26 ` Jarek Poplawski
2007-08-30 8:26 ` Jarek Poplawski
2007-08-30 8:32 ` Jarek Poplawski
2007-08-30 8:32 ` Jarek Poplawski
2007-08-29 19:45 ` Alan Cox
2007-08-30 13:45 ` Jarek Poplawski
2007-08-30 13:02 ` David Newall
2007-08-29 9:59 ` Johannes Berg
2007-08-29 9:59 ` Johannes Berg
2007-08-29 10:35 ` Jiri Slaby
2007-08-29 10:35 ` Jiri Slaby
2007-08-29 13:13 ` Xavier Bestel
2007-08-30 11:59 ` Johannes Berg
2007-08-30 11:59 ` Johannes Berg
2007-08-28 16:01 ` [PATCH 5/5] Net: ath5k, kconfig changes Jiri Slaby
2007-08-28 17:13 ` Christoph Hellwig
2007-08-30 1:38 ` Nick Kossifidis
2007-08-30 12:35 ` Christoph Hellwig
2007-08-30 12:35 ` Christoph Hellwig
2007-08-30 12:36 ` John W. Linville
2007-08-30 12:36 ` John W. Linville
2007-08-30 22:18 ` Nick Kossifidis
2007-09-01 5:58 ` Nick Kossifidis
2007-09-01 5:58 ` Nick Kossifidis
2007-08-31 11:58 ` Dan Williams
2007-08-31 11:58 ` Dan Williams
2007-08-31 13:30 ` Jeff Garzik
2007-08-31 13:30 ` Jeff Garzik
2007-08-31 14:32 ` Dan Williams
2007-08-28 16:22 ` [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals Johannes Berg
2007-08-28 17:08 ` Christoph Hellwig
2007-08-28 17:10 ` Christoph Hellwig
2007-08-28 17:33 ` Johannes Berg
2007-08-28 17:47 ` Larry Finger
2007-08-28 21:50 ` Luis R. Rodriguez
2007-08-30 1:50 ` Nick Kossifidis
2007-08-30 1:50 ` Nick Kossifidis
2007-08-30 12:38 ` John W. Linville [this message]
2007-08-30 12:38 ` John W. Linville
2007-09-01 3:12 ` Nick Kossifidis
2007-09-01 3:12 ` Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070830123849.GB5140@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=hch@infradead.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mickflemm@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.