All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: wang dengyi <dy_wang@yahoo.com>,
	bridge@lists.linux-foundation.org,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org
Subject: [Bridge] Re: [PATCH] bridge: packets leaking out of disabled/blocked ports
Date: Thu, 30 Aug 2007 16:03:13 -0400	[thread overview]
Message-ID: <20070830200313.GF5140@tuxdriver.com> (raw)
In-Reply-To: <20070830122258.1c606516@freepuppy.rosehill.hemminger.net>

On Thu, Aug 30, 2007 at 12:22:58PM -0700, Stephen Hemminger wrote:
> This patch fixes some packet leakage in bridge.  The bridging code
> was allowing forward table entries to be generated even if a device
> was being blocked. The fix is to not add forwarding database entries
> unless the port is active.

Seems reasonable -- ACK

John
-- 
John W. Linville
linville@tuxdriver.com

WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: wang dengyi <dy_wang@yahoo.com>,
	"David S. Miller" <davem@davemloft.net>,
	bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH] bridge: packets leaking out of disabled/blocked ports
Date: Thu, 30 Aug 2007 16:03:13 -0400	[thread overview]
Message-ID: <20070830200313.GF5140@tuxdriver.com> (raw)
In-Reply-To: <20070830122258.1c606516@freepuppy.rosehill.hemminger.net>

On Thu, Aug 30, 2007 at 12:22:58PM -0700, Stephen Hemminger wrote:
> This patch fixes some packet leakage in bridge.  The bridging code
> was allowing forward table entries to be generated even if a device
> was being blocked. The fix is to not add forwarding database entries
> unless the port is active.

Seems reasonable -- ACK

John
-- 
John W. Linville
linville@tuxdriver.com

  reply	other threads:[~2007-08-30 20:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-22 22:36 [Bridge] bridge problem when one interface is in blocking mode wang dengyi
2007-08-23 17:08 ` Stephen Hemminger
2007-08-23 18:17   ` wang dengyi
2007-08-23 18:23     ` Stephen Hemminger
2007-08-29 21:27       ` wang dengyi
2007-08-29 22:05         ` Stephen Hemminger
2007-08-30 15:28           ` wang dengyi
2007-08-30 19:09             ` Srinivas M.A.
2007-08-30 19:22             ` [Bridge] [PATCH] bridge: packets leaking out of disabled/blocked ports Stephen Hemminger
2007-08-30 19:22               ` Stephen Hemminger
2007-08-30 20:03               ` John W. Linville [this message]
2007-08-30 20:03                 ` John W. Linville
2007-08-31  5:15                 ` [Bridge] " David Miller
2007-08-31  5:15                   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070830200313.GF5140@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=dy_wang@yahoo.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.