From: Matthew Wilcox <matthew@wil.cx>
To: Christoph Hellwig <hch@infradead.org>,
Jan Engelhardt <jengelh@computergmbh.de>,
Satyam Sharma <satyam@infradead.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Joe Perches <joe@perches.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] trivial - constify sched.h
Date: Fri, 31 Aug 2007 14:03:33 +0000 [thread overview]
Message-ID: <20070831140332.GB14130@parisc-linux.org> (raw)
In-Reply-To: <20070831135323.GA24509@infradead.org>
On Fri, Aug 31, 2007 at 02:53:23PM +0100, Christoph Hellwig wrote:
> On Thu, Aug 30, 2007 at 10:55:49PM +0200, Jan Engelhardt wrote:
> > "those callers". There was _exactly one_ caller, and that was an out-of-tree
> > module. There were not any in-kernel callers before, and it did not generate
> > any warning. That is perhaps why no one had constified it before me. This does
> > not mean we should wait for a caller to pop up before constifying IMHO.
>
> In this case we should just kill it instead of messing with constness.
I think Jan mis-spoke -- there were no in-kernel callers calling it with
a const argument.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: Christoph Hellwig <hch@infradead.org>,
Jan Engelhardt <jengelh@computergmbh.de>,
Satyam Sharma <satyam@infradead.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Joe Perches <joe@perches.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] trivial - constify sched.h
Date: Fri, 31 Aug 2007 08:03:33 -0600 [thread overview]
Message-ID: <20070831140332.GB14130@parisc-linux.org> (raw)
In-Reply-To: <20070831135323.GA24509@infradead.org>
On Fri, Aug 31, 2007 at 02:53:23PM +0100, Christoph Hellwig wrote:
> On Thu, Aug 30, 2007 at 10:55:49PM +0200, Jan Engelhardt wrote:
> > "those callers". There was _exactly one_ caller, and that was an out-of-tree
> > module. There were not any in-kernel callers before, and it did not generate
> > any warning. That is perhaps why no one had constified it before me. This does
> > not mean we should wait for a caller to pop up before constifying IMHO.
>
> In this case we should just kill it instead of messing with constness.
I think Jan mis-spoke -- there were no in-kernel callers calling it with
a const argument.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-08-31 14:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 20:40 [PATCH] trivial - constify sched.h Joe Perches
2007-08-27 20:40 ` Joe Perches
2007-08-27 20:59 ` Jiri Slaby
2007-08-27 20:59 ` Jiri Slaby
2007-08-27 21:33 ` Alexey Dobriyan
2007-08-27 21:33 ` Alexey Dobriyan
2007-08-30 19:24 ` Jan Engelhardt
2007-08-30 19:24 ` Jan Engelhardt
2007-08-30 20:41 ` Satyam Sharma
2007-08-30 20:53 ` Satyam Sharma
2007-08-30 20:55 ` Jan Engelhardt
2007-08-30 20:55 ` Jan Engelhardt
2007-08-30 21:21 ` Satyam Sharma
2007-08-30 21:33 ` Satyam Sharma
2007-08-31 13:53 ` Christoph Hellwig
2007-08-31 13:53 ` Christoph Hellwig
2007-08-31 14:03 ` Matthew Wilcox [this message]
2007-08-31 14:03 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070831140332.GB14130@parisc-linux.org \
--to=matthew@wil.cx \
--cc=adobriyan@gmail.com \
--cc=hch@infradead.org \
--cc=jengelh@computergmbh.de \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=satyam@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.