All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	len.brown@intel.com, bzolnier@gmail.com, minyard@acm.org,
	rlove@rlove.org, dz@debian.org, Greg KH <greg@kroah.com>,
	stelian@popies.net, dmitry.torokhov@gmail.com,
	ibm-acpi@hmh.eng.br, ak@suse.de, lm-sensors@lm-sensors.org,
	linux-ide@vger.kernel.org, mzxreary@0pointer.de,
	j.w.r.degoede@hhs.nl, Andrew Morton <akpm@linux-foundation.org>,
	gimli@dark-green.com, ambx1@neo.rr.com
Subject: Re: [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and internals
Date: Sun, 2 Sep 2007 19:17:46 +0200	[thread overview]
Message-ID: <20070902191746.6aa9fcae@hyperion.delvare> (raw)
In-Reply-To: <20070901142719.GA31990@havoc.gtf.org>

On Sat, 1 Sep 2007 10:27:19 -0400, Jeff Garzik wrote:
> 
> commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4
> Author: Jeff Garzik <jeff@garzik.org>
> Date:   Sat Sep 1 10:16:45 2007 -0400
> 
>     drivers/firmware: const-ify DMI API and internals
>     
>     Three main sets of changes:
>     
>     1) dmi_get_system_info() return value should have been marked const,
>        since callers should not be changing that data.
>     
>     2) const-ify DMI internals, since DMI firmware tables should,
>        whenever possible, be marked const to ensure we never ever write to
>        that data area.
>     
>     3) const-ify DMI API, to enable marking tables const where possible
>        in low-level drivers.
>     
>     And if we're really lucky, this might enable some additional
>     optimizations on the part of the compiler.
>     
>     The bulk of the changes are #2 and #3, which are interrelated.  #1 could
>     have been a separate patch, but it was so small compared to the others,
>     it was easier to roll it into this changeset.
>     
>     Signed-off-by: Jeff Garzik <jeff@garzik.org>

Looks alright to me, thanks Jeff.

-- 
Jean Delvare

WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	len.brown@intel.com, bzolnier@gmail.com, minyard@acm.org,
	rlove@rlove.org, dz@debian.org, Greg KH <greg@kroah.com>,
	stelian@popies.net, dmitry.torokhov@gmail.com,
	ibm-acpi@hmh.eng.br, ak@suse.de, lm-sensors@lm-sensors.org,
	linux-ide@vger.kernel.org, mzxreary@0pointer.de,
	j.w.r.degoede@hhs.nl, Andrew Morton <akpm@linux-foundation.org>,
	gimli@dark-green.com, ambx1@neo.rr.com
Subject: Re: [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and
Date: Sun, 02 Sep 2007 17:17:46 +0000	[thread overview]
Message-ID: <20070902191746.6aa9fcae@hyperion.delvare> (raw)
In-Reply-To: <20070901142719.GA31990@havoc.gtf.org>

On Sat, 1 Sep 2007 10:27:19 -0400, Jeff Garzik wrote:
> 
> commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4
> Author: Jeff Garzik <jeff@garzik.org>
> Date:   Sat Sep 1 10:16:45 2007 -0400
> 
>     drivers/firmware: const-ify DMI API and internals
>     
>     Three main sets of changes:
>     
>     1) dmi_get_system_info() return value should have been marked const,
>        since callers should not be changing that data.
>     
>     2) const-ify DMI internals, since DMI firmware tables should,
>        whenever possible, be marked const to ensure we never ever write to
>        that data area.
>     
>     3) const-ify DMI API, to enable marking tables const where possible
>        in low-level drivers.
>     
>     And if we're really lucky, this might enable some additional
>     optimizations on the part of the compiler.
>     
>     The bulk of the changes are #2 and #3, which are interrelated.  #1 could
>     have been a separate patch, but it was so small compared to the others,
>     it was easier to roll it into this changeset.
>     
>     Signed-off-by: Jeff Garzik <jeff@garzik.org>

Looks alright to me, thanks Jeff.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2007-09-02 17:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-01 14:27 [PATCH] drivers/firmware: const-ify DMI API and internals Jeff Garzik
2007-09-01 14:27 ` [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and Jeff Garzik
2007-09-01 15:36 ` [PATCH] drivers/firmware: const-ify DMI API and internals Greg KH
2007-09-01 15:36   ` [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and Greg KH
2007-09-01 16:01   ` [PATCH] drivers/firmware: const-ify DMI API and internals Jeff Garzik
2007-09-01 16:01     ` [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and Jeff Garzik
2007-09-09 17:51     ` [PATCH] drivers/firmware: const-ify DMI API and internals Greg KH
2007-09-09 17:51       ` [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and Greg KH
2007-09-09 20:24       ` [PATCH] drivers/firmware: const-ify DMI API and internals Sam Ravnborg
2007-09-09 20:24         ` [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and Sam Ravnborg
2007-09-09 21:12         ` [PATCH] drivers/firmware: const-ify DMI API and internals Greg KH
2007-09-09 21:12           ` [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and Greg KH
2007-09-01 16:33 ` [PATCH] drivers/firmware: const-ify DMI API and internals Andi Kleen
2007-09-01 16:33   ` [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and Andi Kleen
2007-09-01 21:21   ` [PATCH] drivers/firmware: const-ify DMI API and internals Satyam Sharma
2007-09-01 21:33     ` [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and Satyam Sharma
2007-09-02 17:17 ` Jean Delvare [this message]
2007-09-02 17:17   ` Jean Delvare
2007-09-11 21:54 ` [PATCH] drivers/firmware: const-ify DMI API and internals Bartlomiej Zolnierkiewicz
2007-09-11 21:54   ` [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070902191746.6aa9fcae@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=ambx1@neo.rr.com \
    --cc=bzolnier@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dz@debian.org \
    --cc=gimli@dark-green.com \
    --cc=greg@kroah.com \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=j.w.r.degoede@hhs.nl \
    --cc=jeff@garzik.org \
    --cc=len.brown@intel.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=minyard@acm.org \
    --cc=mzxreary@0pointer.de \
    --cc=rlove@rlove.org \
    --cc=stelian@popies.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.