From: "Daniel P. Berrange" <berrange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org
Subject: Re: expose host CPU features to guests
Date: Wed, 5 Sep 2007 20:44:48 +0100 [thread overview]
Message-ID: <20070905194448.GN5503@redhat.com> (raw)
In-Reply-To: <46DF04D5.5000807-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
On Wed, Sep 05, 2007 at 10:34:45PM +0300, Avi Kivity wrote:
> Anthony Liguori wrote:
> > On Wed, 2007-09-05 at 20:45 +0300, danken-atKUWr5tajBWk0Htik3J/w@public.gmane.org wrote:
> >
> >> Hi,
> >>
> >> It's a pity not to use a host CPU feature if it is available. This patch
> >> exposes host CPU features to guests. It allows fine-tuning the presented
> >> features from the command-line.
> >>
> >> The code could use some serious clean ups, but I think it is interesting
> >> enough right now. I'd be happy to hear your opinion and suggestions.
> >> The diff are done against qemu cvs. I tried it with kvm, but I thinkg it
> >> should be useful also for kqemu.
> >>
> >
> > I like this idea but I have some suggestions about the general approach.
> > I think instead of defining another machine type, it would be better to
> > just have a command line option like -cpuid that took a comma separate
> > string of features with "all" meaning all features that the host has.
> >
> >
>
> I think qemu-cvs has a -cpu option for non-x86 which could be used for
> this. Agree machine types are the wrong approach.
Yep, machine types are already used to switch between a different concept
so using the new -cpu option would make sense. Could perhaps extend the
syntax so that instead of '-cpu TYPE' it used '-cpu TYPE,FEATURES' where
FEATURES was an optional list of CPU features to allow - though perhaps
with some shortcut for specifying 'match the host cpu type & features'.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [kvm-devel] expose host CPU features to guests
Date: Wed, 5 Sep 2007 20:44:48 +0100 [thread overview]
Message-ID: <20070905194448.GN5503@redhat.com> (raw)
In-Reply-To: <46DF04D5.5000807@qumranet.com>
On Wed, Sep 05, 2007 at 10:34:45PM +0300, Avi Kivity wrote:
> Anthony Liguori wrote:
> > On Wed, 2007-09-05 at 20:45 +0300, danken@qumranet.com wrote:
> >
> >> Hi,
> >>
> >> It's a pity not to use a host CPU feature if it is available. This patch
> >> exposes host CPU features to guests. It allows fine-tuning the presented
> >> features from the command-line.
> >>
> >> The code could use some serious clean ups, but I think it is interesting
> >> enough right now. I'd be happy to hear your opinion and suggestions.
> >> The diff are done against qemu cvs. I tried it with kvm, but I thinkg it
> >> should be useful also for kqemu.
> >>
> >
> > I like this idea but I have some suggestions about the general approach.
> > I think instead of defining another machine type, it would be better to
> > just have a command line option like -cpuid that took a comma separate
> > string of features with "all" meaning all features that the host has.
> >
> >
>
> I think qemu-cvs has a -cpu option for non-x86 which could be used for
> this. Agree machine types are the wrong approach.
Yep, machine types are already used to switch between a different concept
so using the new -cpu option would make sense. Could perhaps extend the
syntax so that instead of '-cpu TYPE' it used '-cpu TYPE,FEATURES' where
FEATURES was an optional list of CPU features to allow - though perhaps
with some shortcut for specifying 'match the host cpu type & features'.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
next prev parent reply other threads:[~2007-09-05 19:44 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 17:45 expose host CPU features to guests danken-atKUWr5tajBWk0Htik3J/w
2007-09-05 17:45 ` [Qemu-devel] " danken
[not found] ` <20070905174530.GA3945-iWbx9bcAnq+Hk9JtIoIkgNBPR1lH4CV8@public.gmane.org>
2007-09-05 19:26 ` Anthony Liguori
2007-09-05 19:26 ` [Qemu-devel] Re: [kvm-devel] " Anthony Liguori
2007-09-05 19:34 ` Avi Kivity
2007-09-05 19:34 ` [Qemu-devel] Re: [kvm-devel] " Avi Kivity
[not found] ` <46DF04D5.5000807-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-05 19:44 ` Daniel P. Berrange [this message]
2007-09-05 19:44 ` Daniel P. Berrange
[not found] ` <20070905194448.GN5503-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-09-06 0:30 ` [Qemu-devel] " Paul Brook
2007-09-06 0:30 ` [Qemu-devel] Re: [kvm-devel] " Paul Brook
2007-09-06 8:46 ` Avi Kivity
2007-09-06 8:46 ` [Qemu-devel] " Avi Kivity
2007-09-07 10:47 ` [Qemu-devel] " Jamie Lokier
2007-09-07 10:47 ` [Qemu-devel] Re: [kvm-devel] " Jamie Lokier
[not found] ` <20070907104738.GA14723-tp2ajI7sM85Y6zH9YvfY1x2eb7JE58TQ@public.gmane.org>
2007-09-09 7:51 ` [Qemu-devel] " Avi Kivity
2007-09-09 7:51 ` [kvm-devel] " Avi Kivity
[not found] ` <46E3A618.7030505-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-09 12:47 ` Jamie Lokier
2007-09-09 12:47 ` [kvm-devel] " Jamie Lokier
[not found] ` <20070909124718.GE24240-tp2ajI7sM85Y6zH9YvfY1x2eb7JE58TQ@public.gmane.org>
2007-09-09 12:55 ` Avi Kivity
2007-09-09 12:55 ` [kvm-devel] " Avi Kivity
[not found] ` <46E3ED2B.6080606-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-09 13:07 ` Jamie Lokier
2007-09-09 13:07 ` [kvm-devel] " Jamie Lokier
2007-09-09 13:14 ` [kvm-devel] " Avi Kivity
2007-09-09 13:14 ` [kvm-devel] [Qemu-devel] " Avi Kivity
[not found] ` <20070909130725.GF24240-tp2ajI7sM85Y6zH9YvfY1x2eb7JE58TQ@public.gmane.org>
2007-09-09 15:25 ` Paul Brook
2007-09-09 15:25 ` [kvm-devel] " Paul Brook
2007-09-09 15:29 ` [kvm-devel] " Avi Kivity
2007-09-09 15:29 ` [kvm-devel] [Qemu-devel] " Avi Kivity
2007-09-09 15:47 ` [kvm-devel] " Jamie Lokier
2007-09-09 15:47 ` [kvm-devel] [Qemu-devel] " Jamie Lokier
2007-09-09 16:12 ` [kvm-devel] " Paul Brook
2007-09-09 16:12 ` [kvm-devel] [Qemu-devel] " Paul Brook
[not found] ` <200709091712.15743.paul-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org>
2007-09-09 16:38 ` Avi Kivity
2007-09-09 16:38 ` [kvm-devel] " Avi Kivity
2007-09-10 16:53 ` Jamie Lokier
2007-09-10 16:53 ` [kvm-devel] " Jamie Lokier
2007-09-10 7:40 ` expose host CPU features to guests: Take 2 Dan Kenigsberg
2007-09-10 7:40 ` [Qemu-devel] " Dan Kenigsberg
2007-09-10 11:47 ` Natalia Portillo
2007-09-10 12:01 ` Dan Kenigsberg
2007-09-07 16:18 ` Natalia Portillo
2007-09-11 19:48 ` Luke -Jr
2007-09-10 17:16 ` Jamie Lokier
[not found] ` <20070910074005.GA26869-iWbx9bcAnq+Hk9JtIoIkgNBPR1lH4CV8@public.gmane.org>
2007-09-24 17:41 ` expose host CPU features to guests: Take 3 Dan Kenigsberg
2007-09-24 17:41 ` [Qemu-devel] " Dan Kenigsberg
[not found] ` <20070924174129.GA4507-iWbx9bcAnq+Hk9JtIoIkgNBPR1lH4CV8@public.gmane.org>
2007-09-25 1:28 ` andrzej zaborowski
2007-09-25 1:28 ` andrzej zaborowski
[not found] ` <fb249edb0709241828pb6b9fd4v1d1d8d4a3495f040-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-09-25 8:48 ` Dan Kenigsberg
2007-09-25 8:48 ` [kvm-devel] " Dan Kenigsberg
[not found] ` <20070925084842.GA14221-iWbx9bcAnq+Hk9JtIoIkgNBPR1lH4CV8@public.gmane.org>
2007-09-25 9:01 ` Avi Kivity
2007-09-25 9:01 ` [kvm-devel] " Avi Kivity
[not found] ` <46F8CE52.3080502-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-25 9:19 ` J. Mayer
2007-09-25 9:19 ` [kvm-devel] " J. Mayer
2007-09-25 9:31 ` Avi Kivity
2007-09-25 9:31 ` [kvm-devel] " Avi Kivity
[not found] ` <46F8D577.3020306-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-25 10:40 ` Avi Kivity
2007-09-25 10:40 ` [kvm-devel] " Avi Kivity
[not found] ` <46F8E5A2.30906-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-25 11:09 ` J. Mayer
2007-09-25 11:09 ` [kvm-devel] " J. Mayer
2007-09-25 11:36 ` Avi Kivity
2007-09-25 11:36 ` [kvm-devel] " Avi Kivity
[not found] ` <46F8F2B8.1080203-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-25 12:05 ` Fabrice Bellard
2007-09-25 12:05 ` [kvm-devel] " Fabrice Bellard
2007-09-25 13:07 ` Jocelyn Mayer
2007-09-25 13:07 ` [kvm-devel] " Jocelyn Mayer
[not found] ` <1190725664.13490.14.camel-JEa2SU7BmVsPEyPTZiGI+UEOCMrvLtNR@public.gmane.org>
2007-09-25 13:12 ` Avi Kivity
2007-09-25 13:12 ` [kvm-devel] " Avi Kivity
2007-09-25 13:27 ` Dan Kenigsberg
2007-09-25 13:27 ` [kvm-devel] " Dan Kenigsberg
2007-09-25 15:54 ` Jamie Lokier
2007-09-25 16:15 ` Avi Kivity
2007-09-25 12:51 ` Paul Brook
2007-09-25 12:51 ` [kvm-devel] " Paul Brook
[not found] ` <200709251351.55481.paul-qD8j1LwMmJjtCj0u4l0SBw@public.gmane.org>
2007-09-25 13:13 ` Avi Kivity
2007-09-25 13:13 ` [kvm-devel] " Avi Kivity
2007-09-25 9:29 ` Fabrice Bellard
2007-10-07 12:38 ` x86 -cpu option: Take 4 Dan Kenigsberg
2007-10-07 12:38 ` [Qemu-devel] " Dan Kenigsberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070905194448.GN5503@redhat.com \
--to=berrange-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.