From: Andrew Morton <akpm@linux-foundation.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: benh@kernel.crashing.org, linux-kernel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: 2.6.23-rc4-mm1 compile error for ppc 32
Date: Thu, 6 Sep 2007 16:00:09 -0700 [thread overview]
Message-ID: <20070906160009.fa52e8d2.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070906184011.GA1776@Krystal>
> On Thu, 6 Sep 2007 14:40:11 -0400 Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
> Hi Andrew,
>
> Guess what, another one ;)
>
> /opt/crosstool/gcc-4.1.1-glibc-2.3.6/powerpc-405-linux-gnu/bin/powerpc-405-linux-gnu-gcc -m32 -Wp,-MD,arch/ppc/kernel/.asm-offsets.s.d -nostdinc -isystem /opt/crosstool/gcc-4.1.1-glibc-2.3.6/powerpc-405-linux-gnu/lib/gcc/powerpc-405-linux-gnu/4.1.1/include -D__KERNEL__ -Iinclude -Iinclude2 -I/home/compudj/git/linux-2.6-lttng/include -include include/linux/autoconf.h -Iarch/ppc -Iarch/ppc/include -I/home/compudj/git/linux-2.6-lttng/. -I. -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Os -I/home/compudj/git/linux-2.6-lttng/arch/ppc -Iarch/ppc -msoft-float -pipe -ffixed-r2 -mmultiple -mno-altivec -mstring -Wa,-m405 -fomit-frame-pointer -g -fno-stack-protector -Wdeclaration-after-statement -Wno-pointer-sign -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(asm_offsets)" -D"KBUILD_MODNAME=KBUILD_STR(asm_offsets)" -fverbose-asm -S -o arch/ppc/kernel/asm-offsets.s /home/compudj/git/linux-2.6-lttng/arc!
h/ppc/kernel/asm-offsets.c
> In file included from /home/compudj/git/linux-2.6-lttng/include/linux/bitops.h:17,
> from /home/compudj/git/linux-2.6-lttng/include/linux/kernel.h:15,
> from include2/asm/system.h:7,
> from /home/compudj/git/linux-2.6-lttng/include/linux/list.h:9,
> from /home/compudj/git/linux-2.6-lttng/include/linux/signal.h:8,
> from /home/compudj/git/linux-2.6-lttng/arch/ppc/kernel/asm-offsets.c:11:
> arch/ppc/include/asm/bitops.h: In function '__clear_bit_unlock':
> arch/ppc/include/asm/bitops.h:229: error: expected string literal before ':' token
> arch/ppc/include/asm/bitops.h:229: confused by earlier errors, bailing out
> make[2]: *** [arch/ppc/kernel/asm-offsets.s] Error 1
> make[1]: *** [prepare0] Error 2
> make: *** [_all] Error 2
What the heck is arch/ppc/include/asm/bitops.h? I assume that it's
include/asm-powerpc/bitops.h via some wormhole.
If so, the finger points at this:
static __inline__ void __clear_bit_unlock(int nr, volatile unsigned long *addr)
{
__asm__ __volatile__(LWSYNC_ON_SMP ::: "memory");
__clear_bit(nr, addr);
}
which was added by Nick's powerpc-lock-bitops.patch. I am suspecting that
this isn't pp32 code?
(what's with the newly-added old-style __inline__, btw? That's just more
stuff we need to clean up later, so there doesn't seem much point in adding
it).
next prev parent reply other threads:[~2007-09-06 23:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-06 18:40 2.6.23-rc4-mm1 compile error for ppc 32 Mathieu Desnoyers
2007-09-06 23:00 ` Andrew Morton [this message]
2007-09-08 1:36 ` Nick Piggin
2007-09-08 16:42 ` Benjamin Herrenschmidt
2007-09-13 22:17 ` Andrew Morton
2007-09-15 13:32 ` Benjamin Herrenschmidt
2007-09-15 15:00 ` Mathieu Desnoyers
2007-09-17 20:31 ` Benjamin Herrenschmidt
2007-09-17 20:44 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070906160009.fa52e8d2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.