b43 sparse warnings with __CHECK_ENDIAN__

b43 sparse warnings with __CHECK_ENDIAN__

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1924 bytes --]

drivers/net/wireless/b43/xmit.c:124:9: warning: incorrect type in assignment (different base types)
drivers/net/wireless/b43/xmit.c:124:9:    expected restricted unsigned int [usertype] <noident>
drivers/net/wireless/b43/xmit.c:124:9:    got unsigned char 
drivers/net/wireless/b43/xmit.c:126:9: warning: incorrect type in assignment (different base types)
drivers/net/wireless/b43/xmit.c:126:9:    expected restricted unsigned int [usertype] <noident>
drivers/net/wireless/b43/xmit.c:126:9:    got int 
drivers/net/wireless/b43/xmit.c:127:11: warning: incorrect type in argument 1 (different base types)
drivers/net/wireless/b43/xmit.c:127:11:    expected unsigned int [unsigned] [usertype] x
drivers/net/wireless/b43/xmit.c:127:11:    got restricted unsigned int [usertype] <noident>
drivers/net/wireless/b43/pio.c:63:8: warning: cast to restricted type
drivers/net/wireless/b43/pio.c:551:14: warning: incorrect type in assignment (different base types)
drivers/net/wireless/b43/pio.c:551:14:    expected unsigned short [unsigned] [short] <noident>
drivers/net/wireless/b43/pio.c:551:14:    got restricted unsigned short [usertype] [force] <noident>
drivers/net/wireless/b43/pio.c:558:19: warning: incorrect type in assignment (different base types)
drivers/net/wireless/b43/pio.c:558:19:    expected unsigned short [unsigned] [short] <noident>
drivers/net/wireless/b43/pio.c:558:19:    got restricted unsigned short [usertype] [force] <noident>
drivers/net/wireless/b43/pio.c:561:12: warning: cast to restricted type
drivers/net/wireless/b43/pio.c:561:12: warning: cast from restricted type
drivers/net/wireless/b43/pio.c:586:30: warning: incorrect type in assignment (different base types)
drivers/net/wireless/b43/pio.c:586:30:    expected unsigned short [unsigned] [short] [usertype] <noident>
drivers/net/wireless/b43/pio.c:586:30:    got restricted unsigned short [usertype] [force] <noident>


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: b43 sparse warnings with __CHECK_ENDIAN__

[Michael Buesch]

On Thursday 06 September 2007, Johannes Berg wrote:
> drivers/net/wireless/b43/xmit.c:124:9: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/b43/xmit.c:124:9:    expected restricted unsigned int [usertype] <noident>
> drivers/net/wireless/b43/xmit.c:124:9:    got unsigned char 
> drivers/net/wireless/b43/xmit.c:126:9: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/b43/xmit.c:126:9:    expected restricted unsigned int [usertype] <noident>
> drivers/net/wireless/b43/xmit.c:126:9:    got int 
> drivers/net/wireless/b43/xmit.c:127:11: warning: incorrect type in argument 1 (different base types)
> drivers/net/wireless/b43/xmit.c:127:11:    expected unsigned int [unsigned] [usertype] x
> drivers/net/wireless/b43/xmit.c:127:11:    got restricted unsigned int [usertype] <noident>
> drivers/net/wireless/b43/pio.c:63:8: warning: cast to restricted type
> drivers/net/wireless/b43/pio.c:551:14: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/b43/pio.c:551:14:    expected unsigned short [unsigned] [short] <noident>
> drivers/net/wireless/b43/pio.c:551:14:    got restricted unsigned short [usertype] [force] <noident>
> drivers/net/wireless/b43/pio.c:558:19: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/b43/pio.c:558:19:    expected unsigned short [unsigned] [short] <noident>
> drivers/net/wireless/b43/pio.c:558:19:    got restricted unsigned short [usertype] [force] <noident>
> drivers/net/wireless/b43/pio.c:561:12: warning: cast to restricted type
> drivers/net/wireless/b43/pio.c:561:12: warning: cast from restricted type
> drivers/net/wireless/b43/pio.c:586:30: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/b43/pio.c:586:30:    expected unsigned short [unsigned] [short] [usertype] <noident>
> drivers/net/wireless/b43/pio.c:586:30:    got restricted unsigned short [usertype] [force] <noident>

Thanks. I did a patch fixing almost all sparse warnings in b43.
The remaining warning in phy.c will be fixed later.
http://bu3sch.de/patches/wireless-dev/20070907-1702/patches/005-b43-fix-sparse-errors.patch

Re: b43 sparse warnings with __CHECK_ENDIAN__

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

On Fri, 2007-09-07 at 17:05 +0200, Michael Buesch wrote:

> The remaining warning in phy.c will be fixed later.

No worries. I was just running it on mac80211 to check my patches and
then ran it there too so I had the results.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]