From: Andreas Herrmann <aherrman@arcor.de>
To: Jan Kratochvil <honza@jikos.cz>, Dmitry Torokhov <dtor@mail.ru>
Cc: linux-input@atrey.karlin.mff.cuni.cz,
linux-joystick@atrey.karlin.mff.cuni.cz
Subject: [PATCH] xpad: fix Kconfig to avoid compile error
Date: Tue, 18 Sep 2007 11:00:33 +0200 [thread overview]
Message-ID: <20070918090033.GB14882@devil> (raw)
With LEDS_CLASS=m && JOYSTICK_XPAD_LEDS=y I get following compile error:
...
LD .tmp_vmlinux1
drivers/built-in.o: In function `xpad_disconnect':
xpad.c:(.text+0xb3d6b): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `xpad_probe':
xpad.c:(.text+0xb48a6): undefined reference to `led_classdev_register'
make: *** [.tmp_vmlinux1] Error 1
...
To avoid this kernel configuration, do auto-select LEDS_CLASS
for JOYSTCK_XPAD_LEDS.
Signed-off-by: Andreas Herrmann <aherrman@arcor.de>
---
drivers/input/joystick/Kconfig | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig
index e2abe18..d765eb7 100644
--- a/drivers/input/joystick/Kconfig
+++ b/drivers/input/joystick/Kconfig
@@ -277,7 +277,9 @@ config JOYSTICK_XPAD_FF
config JOYSTICK_XPAD_LEDS
bool "LED Support for Xbox360 controller 'BigX' LED"
- depends on LEDS_CLASS && JOYSTICK_XPAD
+ depends on JOYSTICK_XPAD
+ select NEW_LEDS
+ select LEDS_CLASS
---help---
This option enables support for the LED which surrounds the Big X on
XBox 360 controller.
--
1.5.3
next reply other threads:[~2007-09-18 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 9:00 Andreas Herrmann [this message]
2007-09-18 17:41 ` [PATCH] xpad: fix Kconfig to avoid compile error Charles Chambers
2007-09-18 17:50 ` Dmitry Torokhov
2007-09-18 17:52 ` Dmitry Torokhov
2007-09-19 19:16 ` Andreas Herrmann
2007-09-19 19:20 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070918090033.GB14882@devil \
--to=aherrman@arcor.de \
--cc=dtor@mail.ru \
--cc=honza@jikos.cz \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-joystick@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.