All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Herrmann <aherrman@arcor.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jan Kratochvil <honza@jikos.cz>,
	linux-input@atrey.karlin.mff.cuni.cz,
	linux-joystick@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH] xpad: fix Kconfig to avoid compile error
Date: Wed, 19 Sep 2007 21:16:54 +0200	[thread overview]
Message-ID: <20070919191654.GA5115@devil> (raw)
In-Reply-To: <d120d5000709181052r6ee721d6r2d77d0f6b38a4398@mail.gmail.com>

On Tue, Sep 18, 2007 at 01:52:11PM -0400, Dmitry Torokhov wrote:
> > To avoid this kernel configuration, do auto-select LEDS_CLASS
> > for JOYSTCK_XPAD_LEDS.
> >
> 
> I'd rather it depend on LEDS_CLASS (but properly). I believe I posted
> a patch yesterday.

Didn't see this as I am not subscribed to one of the input or joystick mailing lists
(and didn't find any archive for that lists either).
So today I have checked your input.git tree on git.kernel.org.

Your patch (commit be1945c47248fa9c0a7cf4a04c1f4c32928656d2)
works fine if you rename LED_CLASS to LEDS_CLASS ...

So better fix that typo before your tree is pulled into Linus' tree.
;-)


Thanks and Regards,

Andreas

  reply	other threads:[~2007-09-19 19:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-18  9:00 [PATCH] xpad: fix Kconfig to avoid compile error Andreas Herrmann
2007-09-18 17:41 ` Charles Chambers
2007-09-18 17:50   ` Dmitry Torokhov
2007-09-18 17:52 ` Dmitry Torokhov
2007-09-19 19:16   ` Andreas Herrmann [this message]
2007-09-19 19:20     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070919191654.GA5115@devil \
    --to=aherrman@arcor.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=honza@jikos.cz \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-joystick@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.