* ocfs2: inconsequent NULL checking
@ 2007-10-11 12:40 ` Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2007-09-18 18:14 UTC (permalink / raw)
To: Mark Fasheh, kurt.hackel; +Cc: ocfs2-devel, linux-kernel
The Coverity checker spotted the following inconsequent NULL checking in
fs/ocfs2/dlmglue.c:
<-- snip -->
...
int ocfs2_meta_lock_atime(struct inode *inode,
struct vfsmount *vfsmnt,
int *level)
{
...
if (ocfs2_should_update_atime(inode, vfsmnt))
ocfs2_update_inode_atime(inode, bh);
if (bh)
brelse(bh);
...
<-- snip -->
Since commit c11e9fafb398411af7558fca913c2fa4a10b1f48
ocfs2_update_inode_atime() contains an unconditional
dereference of "bh".
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 2+ messages in thread* [Ocfs2-devel] ocfs2: inconsequent NULL checking
@ 2007-10-11 12:40 ` Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2007-10-11 12:40 UTC (permalink / raw)
To: Mark Fasheh, kurt.hackel; +Cc: ocfs2-devel, linux-kernel
The Coverity checker spotted the following inconsequent NULL checking in
fs/ocfs2/dlmglue.c:
<-- snip -->
...
int ocfs2_meta_lock_atime(struct inode *inode,
struct vfsmount *vfsmnt,
int *level)
{
...
if (ocfs2_should_update_atime(inode, vfsmnt))
ocfs2_update_inode_atime(inode, bh);
if (bh)
brelse(bh);
...
<-- snip -->
Since commit c11e9fafb398411af7558fca913c2fa4a10b1f48
ocfs2_update_inode_atime() contains an unconditional
dereference of "bh".
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-11 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-18 18:14 ocfs2: inconsequent NULL checking Adrian Bunk
2007-10-11 12:40 ` [Ocfs2-devel] " Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.