From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@osdl.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: [uml-devel] [PATCH 1/2] UML - Fix registers.c build
Date: Tue, 18 Sep 2007 21:31:23 -0400 [thread overview]
Message-ID: <20070919013123.GA10822@c2.user-mode-linux.org> (raw)
uml-stop-saving-process-fp-state.patch broke the UML/x86_64 build.
On x86_64, sys/ptrace.h has to be included before asm/ptrace.h.
Otherwise, the defines in asm/ptrace.h will ruin the parse of
sys/ptrace.h -
asm/ptrace.h:
#define PTRACE_GETREGS 12
sys/ptrace.h:
enum __ptrace_request
{
...
PTRACE_GETREGS = 12,
...
}
Also, errno.h was missing.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
---
arch/um/os-Linux/sys-x86_64/registers.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6.20/arch/um/os-Linux/sys-x86_64/registers.c
===================================================================
--- linux-2.6.20.orig/arch/um/os-Linux/sys-x86_64/registers.c 2007-09-18 20:51:35.000000000 -0400
+++ linux-2.6.20/arch/um/os-Linux/sys-x86_64/registers.c 2007-09-18 20:52:15.000000000 -0400
@@ -3,9 +3,10 @@
* Licensed under the GPL
*/
+#include <errno.h>
+#include <sys/ptrace.h>
#define __FRAME_OFFSETS
#include <asm/ptrace.h>
-#include <sys/ptrace.h>
#include "longjmp.h"
#include "user.h"
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@osdl.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: [PATCH 1/2] UML - Fix registers.c build
Date: Tue, 18 Sep 2007 21:31:23 -0400 [thread overview]
Message-ID: <20070919013123.GA10822@c2.user-mode-linux.org> (raw)
uml-stop-saving-process-fp-state.patch broke the UML/x86_64 build.
On x86_64, sys/ptrace.h has to be included before asm/ptrace.h.
Otherwise, the defines in asm/ptrace.h will ruin the parse of
sys/ptrace.h -
asm/ptrace.h:
#define PTRACE_GETREGS 12
sys/ptrace.h:
enum __ptrace_request
{
...
PTRACE_GETREGS = 12,
...
}
Also, errno.h was missing.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
---
arch/um/os-Linux/sys-x86_64/registers.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6.20/arch/um/os-Linux/sys-x86_64/registers.c
===================================================================
--- linux-2.6.20.orig/arch/um/os-Linux/sys-x86_64/registers.c 2007-09-18 20:51:35.000000000 -0400
+++ linux-2.6.20/arch/um/os-Linux/sys-x86_64/registers.c 2007-09-18 20:52:15.000000000 -0400
@@ -3,9 +3,10 @@
* Licensed under the GPL
*/
+#include <errno.h>
+#include <sys/ptrace.h>
#define __FRAME_OFFSETS
#include <asm/ptrace.h>
-#include <sys/ptrace.h>
#include "longjmp.h"
#include "user.h"
next reply other threads:[~2007-09-19 1:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 1:31 Jeff Dike [this message]
2007-09-19 1:31 ` [PATCH 1/2] UML - Fix registers.c build Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070919013123.GA10822@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.