From: Jens Axboe <jens.axboe@oracle.com>
To: David Howells <dhowells@redhat.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
akpm@osdl.org,
Medve Emilian-EMMEDVE1 <Emilian.Medve@freescale.com>,
fujita.tomonori@lab.ntt.co.jp, linuxppc-dev@ozlabs.org,
Gala Kumar-B11780 <kumar.gala@freescale.com>,
paulus@samba.org, linux-scsi@vger.kernel.org
Subject: Re: CONFIG_BLK_DEV_BSG=n
Date: Wed, 19 Sep 2007 14:53:18 +0200 [thread overview]
Message-ID: <20070919125318.GE25592@kernel.dk> (raw)
In-Reply-To: <19650.1190040390@redhat.com>
On Mon, Sep 17 2007, David Howells wrote:
>
> James Bottomley <James.Bottomley@SteelEye.com> wrote:
>
> > > Which solution would you be more comfortable with?
> >
> > The one which is currently in -mm is this one:
> >
> > http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=49892223f7d3a2333ef9e6cbdd526676e1fc517a
>
> In my opinion, this is the wrong fix. There shouldn't be anything in
> the kernel using stuff from bsg.h if CONFIG_BLOCK=n, so there should
> be an error if anything tries to. The correct fix is to exclude the
> non-userspace-visible contents of bsg.h with #ifdef CONFIG_BLOCK, not
> to declare things that we've tried to make sure specifically aren't
> declared.
I agree, I'll pass your fix on.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <jens.axboe@oracle.com>
To: David Howells <dhowells@redhat.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
akpm@osdl.org, linux-scsi@vger.kernel.org,
Gala Kumar-B11780 <kumar.gala@freescale.com>,
fujita.tomonori@lab.ntt.co.jp, linuxppc-dev@ozlabs.org,
paulus@samba.org
Subject: Re: CONFIG_BLK_DEV_BSG=n
Date: Wed, 19 Sep 2007 14:53:18 +0200 [thread overview]
Message-ID: <20070919125318.GE25592@kernel.dk> (raw)
In-Reply-To: <19650.1190040390@redhat.com>
On Mon, Sep 17 2007, David Howells wrote:
>
> James Bottomley <James.Bottomley@SteelEye.com> wrote:
>
> > > Which solution would you be more comfortable with?
> >
> > The one which is currently in -mm is this one:
> >
> > http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=49892223f7d3a2333ef9e6cbdd526676e1fc517a
>
> In my opinion, this is the wrong fix. There shouldn't be anything in
> the kernel using stuff from bsg.h if CONFIG_BLOCK=n, so there should
> be an error if anything tries to. The correct fix is to exclude the
> non-userspace-visible contents of bsg.h with #ifdef CONFIG_BLOCK, not
> to declare things that we've tried to make sure specifically aren't
> declared.
I agree, I'll pass your fix on.
--
Jens Axboe
next prev parent reply other threads:[~2007-09-19 12:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 19:50 CONFIG_BLK_DEV_BSG=n Medve Emilian-EMMEDVE1
2007-09-14 19:50 ` CONFIG_BLK_DEV_BSG=n Medve Emilian-EMMEDVE1
2007-09-14 20:00 ` CONFIG_BLK_DEV_BSG=n James Bottomley
2007-09-14 20:00 ` CONFIG_BLK_DEV_BSG=n James Bottomley
2007-09-17 14:46 ` CONFIG_BLK_DEV_BSG=n David Howells
2007-09-17 14:46 ` CONFIG_BLK_DEV_BSG=n David Howells
2007-09-19 12:53 ` Jens Axboe [this message]
2007-09-19 12:53 ` CONFIG_BLK_DEV_BSG=n Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070919125318.GE25592@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=Emilian.Medve@freescale.com \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=kumar.gala@freescale.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.