* [PATCH] E1000: Do not allow requeue of freed skb
@ 2007-09-21 5:00 Krishna Kumar
0 siblings, 0 replies; only message in thread
From: Krishna Kumar @ 2007-09-21 5:00 UTC (permalink / raw)
To: auke-jan.h.kok; +Cc: netdev, davem, Krishna Kumar
Returning BUSY will make qdisc_restart enqueue the skb which was already
freed. The bad skb was correctly freed and we should return NETDEV_TX_OK.
Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
---
diff -ruNp a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
--- a/drivers/net/e1000e/netdev.c 2007-09-21 10:23:29.000000000 +0530
+++ b/drivers/net/e1000e/netdev.c 2007-09-21 10:24:20.000000000 +0530
@@ -3531,7 +3531,7 @@ static int e1000_xmit_frame(struct sk_bu
/* handle pci_map_single() error in e1000_tx_map */
dev_kfree_skb_any(skb);
spin_unlock_irqrestore(&adapter->tx_queue_lock, irq_flags);
- return NETDEV_TX_BUSY;
+ return NETDEV_TX_OK;
}
e1000_tx_queue(adapter, tx_flags, count);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-09-21 4:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-21 5:00 [PATCH] E1000: Do not allow requeue of freed skb Krishna Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.