From: Matt Domsch <Matt_Domsch@dell.com>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Frank Cusack <fcusack@fcusack.com>,
linux-ppp@vger.kernel.org
Subject: Re: [PATCH] ppp_mppe: Don't put InterimKey on the stack
Date: Fri, 21 Sep 2007 14:40:53 +0000 [thread overview]
Message-ID: <20070921144053.GA28101@auslistsprd01.us.dell.com> (raw)
In-Reply-To: <46F3D049.4080006@redhat.com>
On Fri, Sep 21, 2007 at 04:08:09PM +0200, Michal Schmidt wrote:
> Hello,
>
> The interrupt stack can be in the __START_KERNEL_map region in which
> virt_to_page will not work. This caused ppp_mppe to crash on CentOS 5 on x86_64
> (http://bugs.centos.org/view.php?id 76).
>
> The fix is to avoid copying the interim key. We can simply use it in its
> original place, which is kmalloc'd.
Needs a Signed-off-by: line, but otherwise, looks good, and even saves
some stack space. Thanks for tracking this down.
-Matt
--
Matt Domsch
Linux Technology Strategist, Dell Office of the CTO
linux.dell.com & www.dell.com/linux
WARNING: multiple messages have this Message-ID (diff)
From: Matt Domsch <Matt_Domsch@dell.com>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Frank Cusack <fcusack@fcusack.com>,
linux-ppp@vger.kernel.org
Subject: Re: [PATCH] ppp_mppe: Don't put InterimKey on the stack
Date: Fri, 21 Sep 2007 09:40:53 -0500 [thread overview]
Message-ID: <20070921144053.GA28101@auslistsprd01.us.dell.com> (raw)
In-Reply-To: <46F3D049.4080006@redhat.com>
On Fri, Sep 21, 2007 at 04:08:09PM +0200, Michal Schmidt wrote:
> Hello,
>
> The interrupt stack can be in the __START_KERNEL_map region in which
> virt_to_page will not work. This caused ppp_mppe to crash on CentOS 5 on x86_64
> (http://bugs.centos.org/view.php?id=2076).
>
> The fix is to avoid copying the interim key. We can simply use it in its
> original place, which is kmalloc'd.
Needs a Signed-off-by: line, but otherwise, looks good, and even saves
some stack space. Thanks for tracking this down.
-Matt
--
Matt Domsch
Linux Technology Strategist, Dell Office of the CTO
linux.dell.com & www.dell.com/linux
next prev parent reply other threads:[~2007-09-21 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 14:08 [PATCH] ppp_mppe: Don't put InterimKey on the stack Michal Schmidt
2007-09-21 14:08 ` Michal Schmidt
2007-09-21 14:40 ` Matt Domsch [this message]
2007-09-21 14:40 ` Matt Domsch
2007-09-21 14:47 ` Michal Schmidt
2007-09-21 14:47 ` Michal Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070921144053.GA28101@auslistsprd01.us.dell.com \
--to=matt_domsch@dell.com \
--cc=fcusack@fcusack.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=mschmidt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.