All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Henrique de Moraes Holschuh
	<hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
Cc: LM-cy1Wll9GaHOsTnJN9+BGXg@public.gmane.org,
	ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	Len-MRDXTZLjjMs8G+1z+Pypc6QD96bmaF075NbjCUgZEJk@public.gmane.org,
	Sensors ML <lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>,
	linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 8/9] ACPI: thinkpad-acpi: use a separate platform device for hwmon and name it
Date: Mon, 24 Sep 2007 18:43:28 +0200	[thread overview]
Message-ID: <20070924184328.74bfbb9e@hyperion.delvare> (raw)
In-Reply-To: <20070924171128.19f91009-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>

On Mon, 24 Sep 2007 17:11:28 +0200, Jean Delvare wrote:
> On Sun, 23 Sep 2007 11:24:16 -0300, Henrique de Moraes Holschuh wrote:
> > +	tpacpi_sensors_pdev = platform_device_register_simple(
> > +							IBM_HWMON_DRVR_NAME,
> > +							-1, NULL, 0);
> 
> As explained before, libsensors won't pick this device. You'd need to
> give it an id of 0 instead of -1. Hmm, I'll see if I can hack something
> in libsensors4 until that part of the code is reimplemented in a better
> way.

OK, it's fixed in libsensors4 now, the above code will work OK, no need
to change it.

-- 
Jean Delvare

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Henrique de Moraes Holschuh
	<hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
Cc: LM-cy1Wll9GaHOsTnJN9+BGXg@public.gmane.org,
	ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	Len-MRDXTZLjjMs8G+1z+Pypc6QD96bmaF075NbjCUgZEJk@public.gmane.org,
	Sensors ML <lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>,
	linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [lm-sensors] [PATCH 8/9] ACPI: thinkpad-acpi: use a separate
Date: Mon, 24 Sep 2007 16:43:28 +0000	[thread overview]
Message-ID: <20070924184328.74bfbb9e@hyperion.delvare> (raw)
In-Reply-To: <20070924171128.19f91009-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>

On Mon, 24 Sep 2007 17:11:28 +0200, Jean Delvare wrote:
> On Sun, 23 Sep 2007 11:24:16 -0300, Henrique de Moraes Holschuh wrote:
> > +	tpacpi_sensors_pdev = platform_device_register_simple(
> > +							IBM_HWMON_DRVR_NAME,
> > +							-1, NULL, 0);
> 
> As explained before, libsensors won't pick this device. You'd need to
> give it an id of 0 instead of -1. Hmm, I'll see if I can hack something
> in libsensors4 until that part of the code is reimplemented in a better
> way.

OK, it's fixed in libsensors4 now, the above code will work OK, no need
to change it.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2007-09-24 16:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-23 14:24 [GIT PATCH v3] thinkpad-acpi changes for the merge window (part 1) Henrique de Moraes Holschuh
2007-09-23 14:24 ` [PATCH 1/9] ACPI: thinkpad-acpi: make room for more features in tp_features bitfield Henrique de Moraes Holschuh
2007-09-23 14:24 ` [PATCH 2/9] ACPI: thinkpad-acpi: issue EV_SYNC after EV_SWITCH Henrique de Moraes Holschuh
2007-09-23 14:24 ` [PATCH 4/9] ACPI: thinkpad-acpi: keep track of module state Henrique de Moraes Holschuh
2007-09-23 14:24 ` [PATCH 5/9] ACPI: thinkpad-acpi: check version of hot key firmware Henrique de Moraes Holschuh
     [not found] ` <1190557457539-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2007-09-23 14:24   ` [PATCH 3/9] ACPI: thinkpad-acpi: add mutex-based locking to input device event send path Henrique de Moraes Holschuh
2007-09-23 14:24   ` [PATCH 6/9] ACPI: thinkpad-acpi: dequeue all pending hot key events at once (v2.1) Henrique de Moraes Holschuh
2007-09-23 14:24   ` [PATCH 9/9] ACPI: thinkpad-acpi: duplicate driver attributes to new hwmon pdrv Henrique de Moraes Holschuh
2007-09-23 14:24 ` [PATCH 7/9] ACPI: thinkpad-acpi: fix regression on HKEY LID event handling Henrique de Moraes Holschuh
2007-09-23 14:24 ` [PATCH 8/9] ACPI: thinkpad-acpi: use a separate platform device for hwmon and name it Henrique de Moraes Holschuh
2007-09-23 14:24   ` [lm-sensors] [PATCH 8/9] ACPI: thinkpad-acpi: use a separate Henrique de Moraes Holschuh
     [not found]   ` <11905574583315-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2007-09-24 15:11     ` [lm-sensors] [PATCH 8/9] ACPI: thinkpad-acpi: use a separate platform device for hwmon and name it Jean Delvare
2007-09-24 15:11       ` [lm-sensors] [PATCH 8/9] ACPI: thinkpad-acpi: use a separate Jean Delvare
     [not found]       ` <20070924171128.19f91009-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2007-09-24 16:43         ` Jean Delvare [this message]
2007-09-24 16:43           ` Jean Delvare
2007-09-25  2:39         ` [lm-sensors] [PATCH 8/9] ACPI: thinkpad-acpi: use a separate platform device for hwmon and name it Henrique de Moraes Holschuh
2007-09-25  2:39           ` [lm-sensors] [PATCH 8/9] ACPI: thinkpad-acpi: use a Henrique de Moraes Holschuh
2007-09-25 16:00           ` [lm-sensors] [PATCH 8/9] ACPI: thinkpad-acpi: use a separate platform device for hwmon and name it Jean Delvare
2007-09-25 16:00             ` [lm-sensors] [PATCH 8/9] ACPI: thinkpad-acpi: use a separate Jean Delvare
2007-09-25 16:53             ` [lm-sensors] [PATCH 8/9] ACPI: thinkpad-acpi: use a separate platform device for hwmon and name it Henrique de Moraes Holschuh
2007-09-25 16:53               ` [lm-sensors] [PATCH 8/9] ACPI: thinkpad-acpi: use a Henrique de Moraes Holschuh
2007-09-23 14:31 ` [GIT PATCH v3] thinkpad-acpi changes for the merge window (part 1) Henrique de Moraes Holschuh
  -- strict thread matches above, loose matches on Subject: below --
2007-09-23 14:38 [GIT PATCH v3.1] " Henrique de Moraes Holschuh
2007-09-23 14:39 ` [PATCH 8/9] ACPI: thinkpad-acpi: use a separate platform device for hwmon and name it Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070924184328.74bfbb9e@hyperion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=LM-cy1Wll9GaHOsTnJN9+BGXg@public.gmane.org \
    --cc=Len-MRDXTZLjjMs8G+1z+Pypc6QD96bmaF075NbjCUgZEJk@public.gmane.org \
    --cc=hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org \
    --cc=ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.