From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Thomas Klein <tklein@de.ibm.com>,
Jan-Bernd Themann <themann@de.ibm.com>,
Paul Mackerras <pmac@au1.ibm.com>,
Joachim Fenkes <fenkes@de.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Christoph Raisch <raisch@de.ibm.com>,
Paul Mackerras <paulus@samba.org>,
Stefan Roscher <stefan.roscher@de.ibm.com>
Subject: Re: [PATCH 2/5] ibmebus: Remove bus match/probe/remove functions
Date: Tue, 25 Sep 2007 16:29:51 +0200 [thread overview]
Message-ID: <200709251629.52376.arnd@arndb.de> (raw)
In-Reply-To: <200709251411.54465.fenkes@de.ibm.com>
On Tuesday 25 September 2007, Joachim Fenkes wrote:
> ibmebus_{,un}register_driver() are replaced by dummy functions because
> ibmebus is temporarily unusable in this transitional state.
>=20
> Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
> ---
> =A0arch/powerpc/kernel/ibmebus.c | =A0199 ++-----------------------------=
=2D---------
> =A01 files changed, 6 insertions(+), 193 deletions(-)
>=20
Great diffstat!
The description makes it sound like a git-bisect would get broken
by this patch, which should never happen. If the patch indeed
ends up with a broken kernel, it would be better to merge it with
the later patch that fixes the code again.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Joachim Fenkes <fenkes@de.ibm.com>,
Paul Mackerras <paulus@samba.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Klein <tklein@de.ibm.com>,
Jan-Bernd Themann <themann@de.ibm.com>,
Paul Mackerras <pmac@au1.ibm.com>,
Christoph Raisch <raisch@de.ibm.com>,
Stefan Roscher <stefan.roscher@de.ibm.com>
Subject: Re: [PATCH 2/5] ibmebus: Remove bus match/probe/remove functions
Date: Tue, 25 Sep 2007 16:29:51 +0200 [thread overview]
Message-ID: <200709251629.52376.arnd@arndb.de> (raw)
In-Reply-To: <200709251411.54465.fenkes@de.ibm.com>
On Tuesday 25 September 2007, Joachim Fenkes wrote:
> ibmebus_{,un}register_driver() are replaced by dummy functions because
> ibmebus is temporarily unusable in this transitional state.
>
> Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
> ---
> arch/powerpc/kernel/ibmebus.c | 199 ++---------------------------------------
> 1 files changed, 6 insertions(+), 193 deletions(-)
>
Great diffstat!
The description makes it sound like a git-bisect would get broken
by this patch, which should never happen. If the patch indeed
ends up with a broken kernel, it would be better to merge it with
the later patch that fixes the code again.
Arnd <><
next prev parent reply other threads:[~2007-09-25 14:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 12:10 [PATCH 0/5] PowerPC: ibmebus refactoring and fixes Joachim Fenkes
2007-09-25 12:10 ` Joachim Fenkes
2007-09-25 12:11 ` [PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch] Joachim Fenkes
2007-09-25 12:11 ` Joachim Fenkes
2007-09-25 14:27 ` Arnd Bergmann
2007-09-25 14:27 ` Arnd Bergmann
2007-09-26 9:07 ` Joachim Fenkes
2007-09-26 9:07 ` Joachim Fenkes
2007-09-25 12:11 ` [PATCH 2/5] ibmebus: Remove bus match/probe/remove functions Joachim Fenkes
2007-09-25 12:11 ` Joachim Fenkes
2007-09-25 14:29 ` Arnd Bergmann [this message]
2007-09-25 14:29 ` Arnd Bergmann
2007-09-26 9:04 ` Joachim Fenkes
2007-09-26 9:04 ` Joachim Fenkes
2007-09-25 12:12 ` [PATCH 3/5] ibmebus: Add device creation and bus probing based on of_device Joachim Fenkes
2007-09-25 12:12 ` Joachim Fenkes
2007-09-25 14:39 ` Arnd Bergmann
2007-09-25 14:39 ` Arnd Bergmann
2007-09-26 8:58 ` Joachim Fenkes
2007-09-26 8:58 ` Joachim Fenkes
2007-09-25 12:12 ` [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers Joachim Fenkes
2007-09-25 12:12 ` Joachim Fenkes
2007-09-25 14:42 ` Arnd Bergmann
2007-09-25 14:42 ` Arnd Bergmann
2007-09-26 8:43 ` Joachim Fenkes
2007-09-26 8:43 ` Joachim Fenkes
2007-09-25 12:13 ` [PATCH 5/5] ibmebus: More speaking error return code in ibmebus_store_probe() Joachim Fenkes
2007-09-25 12:13 ` Joachim Fenkes
-- strict thread matches above, loose matches on Subject: below --
2007-09-26 9:43 [PATCH 0/5] [REPOST] PowerPC: ibmebus refactoring and fixes Joachim Fenkes
2007-09-26 9:44 ` [PATCH 2/5] ibmebus: Remove bus match/probe/remove functions Joachim Fenkes
2007-09-26 9:44 ` Joachim Fenkes
2007-09-27 11:30 ` Arnd Bergmann
2007-09-27 11:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709251629.52376.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=fenkes@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=pmac@au1.ibm.com \
--cc=raisch@de.ibm.com \
--cc=stefan.roscher@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.