Re: [PATCH 8/8]: Support inserting options during the 3-way

[Arnaldo Carvalho de Melo <acme@ghostprotocols.net>]

Em Wed, Sep 26, 2007 at 10:04:22AM +0100, Gerrit Renker escreveu:
> Quoting Arnaldo Carvalho de Melo:
> |  > --- a/net/dccp/options.c
> |  > +++ b/net/dccp/options.c
> |  > @@ -160,7 +160,7 @@ int dccp_parse_options(struct sock *sk, 
> |  >                       if (len != 4)
> |  >                               goto out_invalid_option;
> |  >  
> |  > -                     tse = dreq? &dreq->dreq_tstamp : dp->dccps_tstamp;
> |  > +                     tse = dreq? &dreq->dreq_tstamp : &dp->dccps_tstamp;
> |  
> |  And here you fix it in an unrelated patch, tsc, tsc :-)

> These kind of errors don't happen on purpose, if I submitted everything as one big patch 
> no one would notice. But with one problem split into several tens of patches it easily 
> happens that one hunk is fixed while quilt is in a different patch - and then it gets assigned 
> the wrong patch. I missed this hunk so thank you two for spotting this - it is fixed now.

Thanks!

Dave pulled the first 6 patches I merged from you and has rebased
2.6.24, I'll follow suit, apply the ones I already have here and
continue the review/test process.

- Arnaldo