From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 8/8]: Support inserting options during the 3-way handshake
Date: Wed, 26 Sep 2007 09:04:22 +0000 [thread overview]
Message-ID: <200709261004.22954@strip-the-willow> (raw)
In-Reply-To: <200709251530.51394@strip-the-willow>
Quoting Arnaldo Carvalho de Melo:
| > --- a/net/dccp/options.c
| > +++ b/net/dccp/options.c
| > @@ -160,7 +160,7 @@ int dccp_parse_options(struct sock *sk,
| > if (len != 4)
| > goto out_invalid_option;
| >
| > - tse = dreq? &dreq->dreq_tstamp : dp->dccps_tstamp;
| > + tse = dreq? &dreq->dreq_tstamp : &dp->dccps_tstamp;
|
| And here you fix it in an unrelated patch, tsc, tsc :-)
These kind of errors don't happen on purpose, if I submitted everything as one big patch
no one would notice. But with one problem split into several tens of patches it easily
happens that one hunk is fixed while quilt is in a different patch - and then it gets assigned
the wrong patch. I missed this hunk so thank you two for spotting this - it is fixed now.
next prev parent reply other threads:[~2007-09-26 9:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 14:30 [PATCH 8/8]: Support inserting options during the 3-way handshake Gerrit Renker
2007-09-25 18:52 ` [PATCH 8/8]: Support inserting options during the 3-way Arnaldo Carvalho de Melo
2007-09-25 23:09 ` [PATCH 8/8]: Support inserting options during the 3-way handshake Ian McDonald
2007-09-26 9:04 ` Gerrit Renker [this message]
2007-09-26 9:45 ` [PATCH 8/8]: Support inserting options during the 3-way Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709261004.22954@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.