* [PATCH] usb_serial: Stop passing NULL to functions that expect data
@ 2007-09-26 22:08 Alan Cox
2007-09-26 22:52 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2007-09-26 22:08 UTC (permalink / raw)
To: akpm, linux-kernel, greg
Earlier patches have removed the checking for old v new differences from
the USB drivers so we can now pass in a valid blank old termios so that
we don't to fill the drivers with magic hacks for console support
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.23rc8-mm1/drivers/serial/serial_core.c linux-2.6.23rc8-mm1/drivers/serial/serial_core.c
--- linux.vanilla-2.6.23rc8-mm1/drivers/serial/serial_core.c 2007-09-26 16:46:54.000000000 +0100
+++ linux-2.6.23rc8-mm1/drivers/serial/serial_core.c 2007-09-18 16:28:20.000000000 +0100
@@ -1885,6 +1885,7 @@
int baud, int parity, int bits, int flow)
{
struct ktermios termios;
+ static struct ktermios dummy;
int i;
/*
@@ -1930,7 +1931,7 @@
*/
port->mctrl |= TIOCM_DTR;
- port->ops->set_termios(port, &termios, NULL);
+ port->ops->set_termios(port, &termios, &dummy);
co->cflag = termios.c_cflag;
return 0;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] usb_serial: Stop passing NULL to functions that expect data
2007-09-26 22:08 [PATCH] usb_serial: Stop passing NULL to functions that expect data Alan Cox
@ 2007-09-26 22:52 ` Andrew Morton
2007-09-26 23:01 ` Alan Cox
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2007-09-26 22:52 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-kernel, greg
On Wed, 26 Sep 2007 23:08:40 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> Earlier patches have removed the checking for old v new differences from
> the USB drivers so we can now pass in a valid blank old termios so that
> we don't to fill the drivers with magic hacks for console support
Are all the prerequisites for these patches in mainline, or are there
dependencies on -mm stuff here?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb_serial: Stop passing NULL to functions that expect data
2007-09-26 22:52 ` Andrew Morton
@ 2007-09-26 23:01 ` Alan Cox
0 siblings, 0 replies; 3+ messages in thread
From: Alan Cox @ 2007-09-26 23:01 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, greg
On Wed, 26 Sep 2007 15:52:48 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Wed, 26 Sep 2007 23:08:40 +0100
> Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> > Earlier patches have removed the checking for old v new differences from
> > the USB drivers so we can now pass in a valid blank old termios so that
> > we don't to fill the drivers with magic hacks for console support
>
> Are all the prerequisites for these patches in mainline, or are there
> dependencies on -mm stuff here?
Sorry pre-req for the USB serial ones is the tty patch I sent you last
chunk that added tty_encode_baud_rate
I'd prefer them to sit in -mm a bit. I'm pretty sure most of them are
100% solid but I also want to see if we get any app breakages caused
by correcting our behaviour
Alan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-09-26 22:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-26 22:08 [PATCH] usb_serial: Stop passing NULL to functions that expect data Alan Cox
2007-09-26 22:52 ` Andrew Morton
2007-09-26 23:01 ` Alan Cox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.