From: Paolo Giarrusso <p.giarrusso@gmail.com>
To: user-mode-linux-devel@lists.sourceforge.net
Cc: Jeff Dike <jdike@addtoit.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [uml-devel] [PATCH] UML - Fix irqstack crash
Date: Wed, 26 Sep 2007 17:42:32 +0200 [thread overview]
Message-ID: <200709261742.44100.p.giarrusso@gmail.com> (raw)
In-Reply-To: <20070924200127.GB25202@c2.user-mode-linux.org>
[-- Attachment #1.1: Type: text/plain, Size: 802 bytes --]
On lunedì 24 settembre 2007, Jeff Dike wrote:
> On Thu, Sep 20, 2007 at 05:57:49PM +0200, Paolo Giarrusso wrote:
> > Yes, indeed - or sign extension on 64bit machines would set to 1 the
> > whole high-word.
> >
> > But using long for that mask makes no difference; either int or long
> > long (or better, either u32 or u64) should be used, given that the
> > used signal range is the same on 32 and 64bit machines, it should
> > be u32 for normal signals or u64 if RT-signals are also allowed.
>
> We don't use RT signals for anything, so we could use u32.
I wasn't sure of that.
> I don't
> see it making much difference though.
Agreed - the only difference is for cleanliness and easy verification.
--
"Doh!" (cit.), I've made another mistake!
Paolo Giarrusso, aka Blaisorblade
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 228 bytes --]
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
[-- Attachment #3: Type: text/plain, Size: 194 bytes --]
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Giarrusso <p.giarrusso@gmail.com>
To: user-mode-linux-devel@lists.sourceforge.net
Cc: Jeff Dike <jdike@addtoit.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [uml-devel] [PATCH] UML - Fix irqstack crash
Date: Wed, 26 Sep 2007 17:42:32 +0200 [thread overview]
Message-ID: <200709261742.44100.p.giarrusso@gmail.com> (raw)
In-Reply-To: <20070924200127.GB25202@c2.user-mode-linux.org>
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
On lunedì 24 settembre 2007, Jeff Dike wrote:
> On Thu, Sep 20, 2007 at 05:57:49PM +0200, Paolo Giarrusso wrote:
> > Yes, indeed - or sign extension on 64bit machines would set to 1 the
> > whole high-word.
> >
> > But using long for that mask makes no difference; either int or long
> > long (or better, either u32 or u64) should be used, given that the
> > used signal range is the same on 32 and 64bit machines, it should
> > be u32 for normal signals or u64 if RT-signals are also allowed.
>
> We don't use RT signals for anything, so we could use u32.
I wasn't sure of that.
> I don't
> see it making much difference though.
Agreed - the only difference is for cleanliness and easy verification.
--
"Doh!" (cit.), I've made another mistake!
Paolo Giarrusso, aka Blaisorblade
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-09-26 15:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 23:33 [uml-devel] [PATCH] UML - Fix irqstack crash Jeff Dike
2007-09-18 23:33 ` Jeff Dike
2007-09-19 0:07 ` [uml-devel] " Andrew Morton
2007-09-19 0:07 ` Andrew Morton
2007-09-20 15:57 ` [uml-devel] " Paolo Giarrusso
2007-09-20 15:57 ` Paolo Giarrusso
2007-09-24 20:01 ` Jeff Dike
2007-09-24 20:01 ` Jeff Dike
2007-09-26 15:42 ` Paolo Giarrusso [this message]
2007-09-26 15:42 ` Paolo Giarrusso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709261742.44100.p.giarrusso@gmail.com \
--to=p.giarrusso@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.