From: Pierre Habouzit <madcoder@debian.org>
To: Marco Costalba <mcostalba@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Git <git@vger.kernel.org>
Subject: Re: Big performance regression with --no-color option in git-log
Date: Sat, 29 Sep 2007 13:01:30 +0200 [thread overview]
Message-ID: <20070929110130.GC4216@artemis.corp> (raw)
In-Reply-To: <e5bfff550709290302h6016c6e8mf9d5dfddce07d985@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]
On Sat, Sep 29, 2007 at 10:02:23AM +0000, Marco Costalba wrote:
> On today git tree
hmmm interesting... Here is what happens with --no-color:
38708 33.2920 diff_tree
23908 20.5628 base_name_compare
18478 15.8926 decode_tree_entry
8310 7.1473 find_pack_entry_one
5654 4.8629 update_tree_entry
2748 2.3635 pretty_print_commit
1838 1.5808 get_one_line
1460 1.2557 .plt
and wihtout it:
2594 18.0893 pretty_print_commit
1887 13.1590 get_one_line
1574 10.9763 find_pack_entry_one
967 6.7434 get_short_sha1
892 6.2204 parse_commit_buffer
863 6.0181 lookup_object
595 4.1492 strbuf_grow
440 3.0683 insert_obj_hash
Why on earth does --no-color has such a different code path ...
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-09-29 11:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-29 10:02 Big performance regression with --no-color option in git-log Marco Costalba
2007-09-29 11:01 ` Pierre Habouzit [this message]
2007-09-29 11:09 ` Pierre Habouzit
2007-09-29 11:29 ` Marco Costalba
2007-09-29 12:35 ` [PATCH 1/1] --color and --no-color git-log options don't need diffs to be computed Pierre Habouzit
2007-09-29 12:52 ` David Kastrup
2007-09-29 12:56 ` Pierre Habouzit
2007-09-29 13:06 ` Marco Costalba
2007-09-29 13:07 ` Marco Costalba
2007-09-29 16:50 ` Fix revision log diff setup, avoid unnecessary diff generation Linus Torvalds
2007-09-29 22:11 ` Junio C Hamano
2007-09-29 17:02 ` [PATCH 1/1] --color and --no-color git-log options don't need diffs to be computed Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070929110130.GC4216@artemis.corp \
--to=madcoder@debian.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mcostalba@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.