From: Pierre Habouzit <madcoder@debian.org>
To: David Kastrup <dak@gnu.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/1] --color and --no-color git-log options don't need diffs to be computed.
Date: Sat, 29 Sep 2007 14:56:33 +0200 [thread overview]
Message-ID: <20070929125633.GC32142@artemis.corp> (raw)
In-Reply-To: <85ve9t8wh7.fsf@lola.goethe.zz>
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
On Sat, Sep 29, 2007 at 12:52:36PM +0000, David Kastrup wrote:
> Pierre Habouzit <madcoder@debian.org> writes:
>
> > Signed-off-by: Pierre Habouzit <madcoder@debian.org>
>
> > - if (strcmp(argv[i], "-z"))
> > - revs->diff = 1;
> > + revs->diff = strcmp(argv[i], "-z")
> > + && strcmp(argv[i], "--color")
> > + && strcmp(argv[i], "--no-color");
> > i += opts - 1;
> > continue;
>
> This can clear a previously set value of revs->diff.
Good catch, that should be |= of course.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-09-29 12:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-29 10:02 Big performance regression with --no-color option in git-log Marco Costalba
2007-09-29 11:01 ` Pierre Habouzit
2007-09-29 11:09 ` Pierre Habouzit
2007-09-29 11:29 ` Marco Costalba
2007-09-29 12:35 ` [PATCH 1/1] --color and --no-color git-log options don't need diffs to be computed Pierre Habouzit
2007-09-29 12:52 ` David Kastrup
2007-09-29 12:56 ` Pierre Habouzit [this message]
2007-09-29 13:06 ` Marco Costalba
2007-09-29 13:07 ` Marco Costalba
2007-09-29 16:50 ` Fix revision log diff setup, avoid unnecessary diff generation Linus Torvalds
2007-09-29 22:11 ` Junio C Hamano
2007-09-29 17:02 ` [PATCH 1/1] --color and --no-color git-log options don't need diffs to be computed Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070929125633.GC32142@artemis.corp \
--to=madcoder@debian.org \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.