All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: nuclearcat@nuclearcat.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: 2.6.21 -> 2.6.22 & 2.6.23-rc8 performance regression
Date: Mon, 01 Oct 2007 13:57:10 -0700 (PDT)	[thread overview]
Message-ID: <20071001.135710.99174896.davem@davemloft.net> (raw)
In-Reply-To: <4701541B.70108@cosmosbay.com>

From: Eric Dumazet <dada1@cosmosbay.com>
Date: Mon, 01 Oct 2007 22:10:03 +0200

> So maybe the following patch is necessary...
> 
> I believe IPV6 & DCCP are immune to this problem.
> 
> Thanks again Denys for spotting this.
> 
> Eric
> 
> [PATCH] TCP : secure_tcp_sequence_number() should not use a too fast clock
> 
> TCP V4 sequence numbers are 32bits, and RFC 793 assumed a 250 KHz clock.
> In order to follow network speed increase, we can use a faster clock, but
> we should limit this clock so that the delay between two rollovers is
> greater than MSL (TCP Maximum Segment Lifetime : 2 minutes)
> 
> Choosing a 64 nsec clock should be OK, since the rollovers occur every
> 274 seconds.
> 
> Problem spotted by Denys Fedoryshchenko
> 
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>

Thanks a lot Eric for bringing closure to this.

I'll apply this and add a reference in the commit message to the
changeset that introduced this problem, since it might help
others who look at this.

  reply	other threads:[~2007-10-01 20:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-30 14:48 2.6.21 -> 2.6.22 & 2.6.23-rc8 performance regression Denys
2007-09-30 17:48 ` Eric Dumazet
2007-09-30  4:25   ` Nick Piggin
2007-09-30 22:04     ` Denys
2007-10-01 10:01       ` Andi Kleen
2007-10-01 10:30         ` Denys
2007-10-01 11:14           ` Andi Kleen
2007-10-01 11:52             ` Denys
2007-10-01 11:57               ` Andi Kleen
2007-10-01 12:04                 ` Denys
2007-09-30 22:35     ` Denys
2007-10-01  5:59       ` Eric Dumazet
2007-10-01  7:12         ` David Miller
2007-10-01  8:07           ` Denys
2007-10-01  8:20             ` Eric Dumazet
2007-10-01  8:35               ` Eric Dumazet
2007-10-01 12:10               ` Denys
2007-10-01 13:26               ` Denys
2007-10-01 20:10         ` Eric Dumazet
2007-10-01 20:57           ` David Miller [this message]
2007-09-30 23:24     ` Denys
2007-10-01  6:43     ` Denys
2007-09-30 18:45   ` Denys
  -- strict thread matches above, loose matches on Subject: below --
2007-09-30 15:22 Denys
2007-09-30 17:31 Denys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071001.135710.99174896.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dada1@cosmosbay.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nuclearcat@nuclearcat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.