All of lore.kernel.org
 help / color / mirror / Atom feed
* + ircomm-discovery-indication-simplification.patch added to -mm tree
@ 2007-10-03 21:22 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2007-10-03 21:22 UTC (permalink / raw)
  To: mm-commits; +Cc: ryanr23, samuel


The patch titled
     IrCOMM discovery indication simplification
has been added to the -mm tree.  Its filename is
     ircomm-discovery-indication-simplification.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: IrCOMM discovery indication simplification
From: Ryan Reading <ryanr23@gmail.com>

Every IrCOMM socket is registered with the discovery subsystem, so we don't
need to loop over all of them for every discovery event. We just need to
do it for the registered IrCOMM socket.

Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---


diff -puN net/irda/ircomm/ircomm_tty_attach.c~ircomm-discovery-indication-simplification net/irda/ircomm/ircomm_tty_attach.c
--- a/net/irda/ircomm/ircomm_tty_attach.c~ircomm-discovery-indication-simplification
+++ a/net/irda/ircomm/ircomm_tty_attach.c
@@ -381,18 +381,9 @@ static void ircomm_tty_discovery_indicat
 	info.daddr = discovery->daddr;
 	info.saddr = discovery->saddr;
 
-	/* FIXME. We have a locking problem on the hashbin here.
-	 * We probably need to use hashbin_find_next(), but we first
-	 * need to ensure that "line" is unique. - Jean II */
-	self = (struct ircomm_tty_cb *) hashbin_get_first(ircomm_tty);
-	while (self != NULL) {
-		IRDA_ASSERT(self->magic == IRCOMM_TTY_MAGIC, return;);
-
-		ircomm_tty_do_event(self, IRCOMM_TTY_DISCOVERY_INDICATION,
-				    NULL, &info);
-
-		self = (struct ircomm_tty_cb *) hashbin_get_next(ircomm_tty);
-	}
+	self = (struct ircomm_tty_cb *) priv;
+	ircomm_tty_do_event(self, IRCOMM_TTY_DISCOVERY_INDICATION,
+			    NULL, &info);
 }
 
 /*
_

Patches currently in -mm which might be from ryanr23@gmail.com are

ircomm-discovery-indication-simplification.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-10-03 21:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-03 21:22 + ircomm-discovery-indication-simplification.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.