From: Christoph Lameter <clameter@sgi.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [07/18] Vcompound: Add compound_nth_page() to determine nth base page
Date: Wed, 03 Oct 2007 20:59:42 -0700 [thread overview]
Message-ID: <20071004040003.303112696@sgi.com> (raw)
In-Reply-To: 20071004035935.042951211@sgi.com
[-- Attachment #1: vcompound_compound_nth_page --]
[-- Type: text/plain, Size: 4137 bytes --]
Add a new function
compound_nth_page(page, n)
and
vmalloc_nth_page(page, n)
to find the nth page of a compound page. For real compound pages
his simply reduces to page + n. For virtual compound pages we need to consult
the page tables to figure out the nth page from the one specified.
Update all the references to page[1] to use compound_nth instead.
---
include/linux/mm.h | 17 +++++++++++++----
mm/page_alloc.c | 16 +++++++++++-----
mm/vmalloc.c | 10 ++++++++++
3 files changed, 34 insertions(+), 9 deletions(-)
Index: linux-2.6/include/linux/mm.h
===================================================================
--- linux-2.6.orig/include/linux/mm.h 2007-10-03 19:31:45.000000000 -0700
+++ linux-2.6/include/linux/mm.h 2007-10-03 19:31:51.000000000 -0700
@@ -295,6 +295,8 @@ static inline int get_page_unless_zero(s
}
void *vmalloc_address(struct page *);
+struct page *vmalloc_to_page(void *addr);
+struct page *vmalloc_nth_page(struct page *page, int n);
static inline struct page *compound_head(struct page *page)
{
@@ -338,27 +340,34 @@ void split_page(struct page *page, unsig
*/
typedef void compound_page_dtor(struct page *);
+static inline struct page *compound_nth_page(struct page *page, int n)
+{
+ if (likely(!PageVcompound(page)))
+ return page + n;
+ return vmalloc_nth_page(page, n);
+}
+
static inline void set_compound_page_dtor(struct page *page,
compound_page_dtor *dtor)
{
- page[1].lru.next = (void *)dtor;
+ compound_nth_page(page, 1)->lru.next = (void *)dtor;
}
static inline compound_page_dtor *get_compound_page_dtor(struct page *page)
{
- return (compound_page_dtor *)page[1].lru.next;
+ return (compound_page_dtor *)compound_nth_page(page, 1)->lru.next;
}
static inline int compound_order(struct page *page)
{
if (!PageHead(page))
return 0;
- return (unsigned long)page[1].lru.prev;
+ return (unsigned long)compound_nth_page(page, 1)->lru.prev;
}
static inline void set_compound_order(struct page *page, unsigned long order)
{
- page[1].lru.prev = (void *)order;
+ compound_nth_page(page, 1)->lru.prev = (void *)order;
}
/*
Index: linux-2.6/mm/vmalloc.c
===================================================================
--- linux-2.6.orig/mm/vmalloc.c 2007-10-03 19:31:45.000000000 -0700
+++ linux-2.6/mm/vmalloc.c 2007-10-03 19:31:51.000000000 -0700
@@ -541,6 +541,16 @@ void *vmalloc(unsigned long size)
}
EXPORT_SYMBOL(vmalloc);
+/*
+ * Given a pointer to the first page struct:
+ * Determine a pointer to the nth page.
+ */
+struct page *vmalloc_nth_page(struct page *page, int n)
+{
+ return vmalloc_to_page(page_address(page) + n * PAGE_SIZE);
+}
+EXPORT_SYMBOL(vmalloc_nth_page);
+
/**
* vmalloc_user - allocate zeroed virtually contiguous memory for userspace
* @size: allocation size
Index: linux-2.6/mm/page_alloc.c
===================================================================
--- linux-2.6.orig/mm/page_alloc.c 2007-10-03 19:31:51.000000000 -0700
+++ linux-2.6/mm/page_alloc.c 2007-10-03 19:32:45.000000000 -0700
@@ -274,7 +274,7 @@ static void prep_compound_page(struct pa
set_compound_order(page, order);
__SetPageHead(page);
for (i = 1; i < nr_pages; i++) {
- struct page *p = page + i;
+ struct page *p = compound_nth_page(page, i);
__SetPageTail(p);
p->first_page = page;
@@ -289,17 +289,23 @@ static void destroy_compound_page(struct
if (unlikely(compound_order(page) != order))
bad_page(page);
- if (unlikely(!PageHead(page)))
- bad_page(page);
- __ClearPageHead(page);
for (i = 1; i < nr_pages; i++) {
- struct page *p = page + i;
+ struct page *p = compound_nth_page(page, i);
if (unlikely(!PageTail(p) |
(p->first_page != page)))
bad_page(page);
__ClearPageTail(p);
}
+
+ /*
+ * The PageHead is important since it determines how operations on
+ * a compound page have to be performed. We can only tear the head
+ * down after all the tail pages are done.
+ */
+ if (unlikely(!PageHead(page)))
+ bad_page(page);
+ __ClearPageHead(page);
}
static inline void prep_zero_page(struct page *page, int order, gfp_t gfp_flags)
--
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <clameter@sgi.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [07/18] Vcompound: Add compound_nth_page() to determine nth base page
Date: Wed, 03 Oct 2007 20:59:42 -0700 [thread overview]
Message-ID: <20071004040003.303112696@sgi.com> (raw)
In-Reply-To: 20071004035935.042951211@sgi.com
[-- Attachment #1: vcompound_compound_nth_page --]
[-- Type: text/plain, Size: 4363 bytes --]
Add a new function
compound_nth_page(page, n)
and
vmalloc_nth_page(page, n)
to find the nth page of a compound page. For real compound pages
his simply reduces to page + n. For virtual compound pages we need to consult
the page tables to figure out the nth page from the one specified.
Update all the references to page[1] to use compound_nth instead.
---
include/linux/mm.h | 17 +++++++++++++----
mm/page_alloc.c | 16 +++++++++++-----
mm/vmalloc.c | 10 ++++++++++
3 files changed, 34 insertions(+), 9 deletions(-)
Index: linux-2.6/include/linux/mm.h
===================================================================
--- linux-2.6.orig/include/linux/mm.h 2007-10-03 19:31:45.000000000 -0700
+++ linux-2.6/include/linux/mm.h 2007-10-03 19:31:51.000000000 -0700
@@ -295,6 +295,8 @@ static inline int get_page_unless_zero(s
}
void *vmalloc_address(struct page *);
+struct page *vmalloc_to_page(void *addr);
+struct page *vmalloc_nth_page(struct page *page, int n);
static inline struct page *compound_head(struct page *page)
{
@@ -338,27 +340,34 @@ void split_page(struct page *page, unsig
*/
typedef void compound_page_dtor(struct page *);
+static inline struct page *compound_nth_page(struct page *page, int n)
+{
+ if (likely(!PageVcompound(page)))
+ return page + n;
+ return vmalloc_nth_page(page, n);
+}
+
static inline void set_compound_page_dtor(struct page *page,
compound_page_dtor *dtor)
{
- page[1].lru.next = (void *)dtor;
+ compound_nth_page(page, 1)->lru.next = (void *)dtor;
}
static inline compound_page_dtor *get_compound_page_dtor(struct page *page)
{
- return (compound_page_dtor *)page[1].lru.next;
+ return (compound_page_dtor *)compound_nth_page(page, 1)->lru.next;
}
static inline int compound_order(struct page *page)
{
if (!PageHead(page))
return 0;
- return (unsigned long)page[1].lru.prev;
+ return (unsigned long)compound_nth_page(page, 1)->lru.prev;
}
static inline void set_compound_order(struct page *page, unsigned long order)
{
- page[1].lru.prev = (void *)order;
+ compound_nth_page(page, 1)->lru.prev = (void *)order;
}
/*
Index: linux-2.6/mm/vmalloc.c
===================================================================
--- linux-2.6.orig/mm/vmalloc.c 2007-10-03 19:31:45.000000000 -0700
+++ linux-2.6/mm/vmalloc.c 2007-10-03 19:31:51.000000000 -0700
@@ -541,6 +541,16 @@ void *vmalloc(unsigned long size)
}
EXPORT_SYMBOL(vmalloc);
+/*
+ * Given a pointer to the first page struct:
+ * Determine a pointer to the nth page.
+ */
+struct page *vmalloc_nth_page(struct page *page, int n)
+{
+ return vmalloc_to_page(page_address(page) + n * PAGE_SIZE);
+}
+EXPORT_SYMBOL(vmalloc_nth_page);
+
/**
* vmalloc_user - allocate zeroed virtually contiguous memory for userspace
* @size: allocation size
Index: linux-2.6/mm/page_alloc.c
===================================================================
--- linux-2.6.orig/mm/page_alloc.c 2007-10-03 19:31:51.000000000 -0700
+++ linux-2.6/mm/page_alloc.c 2007-10-03 19:32:45.000000000 -0700
@@ -274,7 +274,7 @@ static void prep_compound_page(struct pa
set_compound_order(page, order);
__SetPageHead(page);
for (i = 1; i < nr_pages; i++) {
- struct page *p = page + i;
+ struct page *p = compound_nth_page(page, i);
__SetPageTail(p);
p->first_page = page;
@@ -289,17 +289,23 @@ static void destroy_compound_page(struct
if (unlikely(compound_order(page) != order))
bad_page(page);
- if (unlikely(!PageHead(page)))
- bad_page(page);
- __ClearPageHead(page);
for (i = 1; i < nr_pages; i++) {
- struct page *p = page + i;
+ struct page *p = compound_nth_page(page, i);
if (unlikely(!PageTail(p) |
(p->first_page != page)))
bad_page(page);
__ClearPageTail(p);
}
+
+ /*
+ * The PageHead is important since it determines how operations on
+ * a compound page have to be performed. We can only tear the head
+ * down after all the tail pages are done.
+ */
+ if (unlikely(!PageHead(page)))
+ bad_page(page);
+ __ClearPageHead(page);
}
static inline void prep_zero_page(struct page *page, int order, gfp_t gfp_flags)
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-10-04 4:02 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 3:59 [00/18] Virtual Compound Page Support V2 Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` [01/18] vmalloc: clean up page array indexing Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` [02/18] vunmap: return page array passed on vmap() Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` [03/18] vmalloc_address(): Determine vmalloc address from page struct Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` [04/18] Vcompound: Smart up virt_to_head_page() Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` [05/18] Page flags: Add PageVcompound() Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` [06/18] Vcompound: Update page address determination Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter [this message]
2007-10-04 3:59 ` [07/18] Vcompound: Add compound_nth_page() to determine nth base page Christoph Lameter
2007-10-13 16:46 ` Compiling kernel 2.6.23.1 HELP animesh saxena
2007-10-13 17:12 ` Willy Tarreau
2007-10-14 2:35 ` Kristoffer Ericson
2007-10-04 3:59 ` [08/18] GFP_VFALLBACK: Allow fallback of compound pages to virtual mappings Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` [09/18] Vcompound: GFP_VFALLBACK debugging aid Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` [10/18] Sparsemem: Use fallback for the memmap Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` [11/18] Page allocator: Use a higher order allocation for the zone wait table Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` [12/18] Wait: Allow bit_waitqueue to wait on a bit in a virtual compound page Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` [13/18] x86_64: Allow fallback for the stack Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 11:56 ` Andi Kleen
2007-10-04 11:56 ` Andi Kleen
2007-10-04 12:08 ` Peter Zijlstra
2007-10-04 12:08 ` Peter Zijlstra
2007-10-04 12:25 ` Andi Kleen
2007-10-04 12:25 ` Andi Kleen
2007-10-04 12:30 ` Peter Zijlstra
2007-10-04 12:30 ` Peter Zijlstra
2007-10-04 17:40 ` Christoph Lameter
2007-10-04 17:40 ` Christoph Lameter
2007-10-04 19:20 ` Christoph Lameter
2007-10-04 19:20 ` Christoph Lameter
2007-10-04 19:39 ` Rik van Riel
2007-10-04 19:39 ` Rik van Riel
2007-10-04 21:20 ` Christoph Lameter
2007-10-04 21:20 ` Christoph Lameter
2007-10-07 7:35 ` Nick Piggin
2007-10-07 7:35 ` Nick Piggin
2007-10-08 17:36 ` Christoph Lameter
2007-10-08 17:36 ` Christoph Lameter
2007-10-08 12:55 ` Nick Piggin
2007-10-08 12:55 ` Nick Piggin
2007-10-09 18:39 ` Christoph Lameter
2007-10-09 18:39 ` Christoph Lameter
2007-10-09 8:46 ` Nick Piggin
2007-10-09 8:46 ` Nick Piggin
2007-10-10 1:26 ` Christoph Lameter
2007-10-10 1:26 ` Christoph Lameter
2007-10-09 9:56 ` Nick Piggin
2007-10-09 9:56 ` Nick Piggin
2007-10-10 3:36 ` where to get ZONE_MOVABLE pathces? Jacky(GuangXiang Lee)
2007-10-10 10:32 ` Mel Gorman
2007-10-06 18:53 ` [13/18] x86_64: Allow fallback for the stack Bill Davidsen
2007-10-06 18:53 ` Bill Davidsen
2007-10-04 3:59 ` [14/18] Configure stack size Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 4:36 ` Arjan van de Ven
2007-10-04 4:36 ` Arjan van de Ven
2007-10-04 4:43 ` David Miller
2007-10-04 4:43 ` David Miller, Arjan van de Ven
2007-10-04 19:34 ` Christoph Lameter
2007-10-04 19:34 ` Christoph Lameter
2007-10-04 9:11 ` Andi Kleen
2007-10-04 9:11 ` Andi Kleen
2007-10-04 19:26 ` Christoph Lameter
2007-10-04 19:26 ` Christoph Lameter
2007-10-04 3:59 ` [15/18] Fallback for temporary order 2 allocation Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` [16/18] Virtual Compound page allocation from interrupt context Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` [17/18] Virtual compound page freeing in " Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
2007-10-04 3:59 ` [18/18] SLUB: Use fallback for table of callers/freers of a slab cache Christoph Lameter
2007-10-04 3:59 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004040003.303112696@sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.