CodingStyle: mention bitfields/whitespace style, prefer (!foo) in examples

CodingStyle: mention bitfields/whitespace style, prefer (!foo) in examples

[Pavel Machek]

Mention whitespace and bitfields style, prefer (!foo) to (foo == NULL)
in examples.

Signed-off-by: Pavel Machek <pavel@suse.cz>

diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
index 7f1730f..1595a45 100644
--- a/Documentation/CodingStyle
+++ b/Documentation/CodingStyle
@@ -71,6 +71,15 @@ used for indentation, and the above exam
 
 Get a decent editor and don't leave whitespace at the end of lines.
 
+Bitfield variables should be indented like this:
+
+	unsigned int foo :1;
+
+Do not put whitespace between any of the unary operators and their operand.
+
+It is usually unnecessary to have whitespace around parentheses as
+part of expressions, around brackets, or around the operators . and
+->.
 
 		Chapter 2: Breaking long lines and strings
 
@@ -403,7 +412,7 @@ int fun(int a)
 	int result = 0;
 	char *buffer = kmalloc(SIZE);
 
-	if (buffer == NULL)
+	if (!buffer)
 		return -ENOMEM;
 
 	if (condition1) {

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: CodingStyle: mention bitfields/whitespace style, prefer (!foo) in examples

[Jan Engelhardt]

On Oct 4 2007 11:44, Pavel Machek wrote:
>diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
>index 7f1730f..1595a45 100644
>--- a/Documentation/CodingStyle
>+++ b/Documentation/CodingStyle
>@@ -71,6 +71,15 @@ used for indentation, and the above exam
> 
> Get a decent editor and don't leave whitespace at the end of lines.
> 
>+Bitfield variables should be indented like this:
>+
>+	unsigned int foo :1;

Current code uses foo:1.

Re: CodingStyle: mention bitfields/whitespace style, prefer (!foo) in examples

[Pavel Machek]

On Thu 2007-10-04 11:51:35, Jan Engelhardt wrote:
> 
> On Oct 4 2007 11:44, Pavel Machek wrote:
> >diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
> >index 7f1730f..1595a45 100644
> >--- a/Documentation/CodingStyle
> >+++ b/Documentation/CodingStyle
> >@@ -71,6 +71,15 @@ used for indentation, and the above exam
> > 
> > Get a decent editor and don't leave whitespace at the end of lines.
> > 
> >+Bitfield variables should be indented like this:
> >+
> >+	unsigned int foo :1;
> 
> Current code uses foo:1.

I'm fine with foo :1 or foo:1. It just would be nice to have example
specifying one way...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: CodingStyle: mention bitfields/whitespace style, prefer (!foo) in examples

[Stefan Richter]

Pavel Machek wrote:
> It just would be nice to have example specifying one way...

I don't see a necessity.
-- 
Stefan Richter
-=====-=-=== =-=- --==-
http://arcgraph.de/sr/