From: Andrew Morton <akpm@linux-foundation.org>
To: Fengguang Wu <wfg@mail.ustc.edu.cn>
Cc: linux-kernel@vger.kernel.org, dgc@sgi.com, kenchen@google.com,
mrubin@google.com
Subject: Re: [PATCH 4/5] writeback: remove pages_skipped accounting in __block_write_full_page()
Date: Thu, 4 Oct 2007 14:26:41 -0700 [thread overview]
Message-ID: <20071004142641.9de1ef66.akpm@linux-foundation.org> (raw)
In-Reply-To: <391315778.53500@ustc.edu.cn>
On Tue, 02 Oct 2007 16:41:47 +0800
Fengguang Wu <wfg@mail.ustc.edu.cn> wrote:
> This patch fixes this bug. Though I'm not sure why __block_write_full_page()
> is called only to do nothing and who actually issued the writeback for us.
kjourald wrote the page's buffers back (ext3 in ordered-data mode). The VM
didn't know about that, so we have a PageDirty page which has clean
buffers.
We rely upon the VFS writeback code to "discover" that this dirty page has
clean buffers: the VFS will attempt to write the dirty page and will end up
marking the page clean without performing any IO.
next prev parent reply other threads:[~2007-10-04 21:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 8:41 [PATCH 0/5] sluggish writeback fixes Fengguang Wu
2007-10-02 8:41 ` Fengguang Wu
2007-10-03 11:04 ` Martin Knoblauch
2007-10-02 8:41 ` [PATCH 1/5] revert check_dirty_inode_list.patch Fengguang Wu
2007-10-02 8:41 ` Fengguang Wu
2007-10-02 8:41 ` [PATCH 2/5] writeback: fix time ordering of the per superblock inode lists 8 Fengguang Wu
2007-10-02 8:41 ` Fengguang Wu
2007-10-02 8:41 ` [PATCH 3/5] writeback: fix ntfs with sb_has_dirty_inodes() Fengguang Wu
2007-10-02 8:41 ` Fengguang Wu
2007-10-02 8:41 ` [PATCH 4/5] writeback: remove pages_skipped accounting in __block_write_full_page() Fengguang Wu
2007-10-02 8:41 ` Fengguang Wu
2007-10-04 21:26 ` Andrew Morton [this message]
2007-10-02 21:55 ` David Chinner
2007-10-03 1:43 ` Fengguang Wu
2007-10-03 1:43 ` Fengguang Wu
2007-10-03 2:22 ` David Chinner
2007-10-02 8:41 ` [PATCH 5/5] writeback: introduce writeback_control.more_io to indicate more io Fengguang Wu
2007-10-02 8:41 ` Fengguang Wu
2007-10-02 21:47 ` David Chinner
2007-10-03 1:34 ` Fengguang Wu
2007-10-03 1:34 ` Fengguang Wu
2007-10-03 2:41 ` David Chinner
2007-10-04 2:21 ` Fengguang Wu
2007-10-04 2:21 ` Fengguang Wu
2007-10-04 5:03 ` David Chinner
2007-10-05 3:36 ` Fengguang Wu
2007-10-05 3:36 ` Fengguang Wu
2007-10-05 7:41 ` David Chinner
2007-10-05 11:55 ` Fengguang Wu
2007-10-05 11:55 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004142641.9de1ef66.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dgc@sgi.com \
--cc=kenchen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mrubin@google.com \
--cc=wfg@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.