All of lore.kernel.org
 help / color / mirror / Atom feed
From: linas@austin.ibm.com (Linas Vepstas)
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org, linuxppc-dev@ozlabs.org,
	linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure
Date: Thu, 4 Oct 2007 13:36:29 -0500	[thread overview]
Message-ID: <20071004183629.GH4338@austin.ibm.com> (raw)
In-Reply-To: <20071002012730.GO12049@parisc-linux.org>

On Mon, Oct 01, 2007 at 07:27:30PM -0600, Matthew Wilcox wrote:
> 
> The thing to remember is that sym2 is in transition from being a dual
> BSD/Linux driver to being a purely Linux driver. 

I was wondering about that; couldn't tell if the split in the code
was historical, or being intentionally maintained.

> > My gut instinct is to say "ack", although prudence dictates that 
> > I should test first. Which might take a few days...
> 
> Fine by me.  

I tested the patch, it worked great. It also seemed to recover 
much more quickly -- so quickly, in fact, that I thought something 
had gone wrong.

I reviewed it one more time, it really does look good. A formal
submission and acked by's at earliest convenience would be good. 

--linas


WARNING: multiple messages have this Message-ID (diff)
From: linas@austin.ibm.com (Linas Vepstas)
To: Matthew Wilcox <matthew@wil.cx>
Cc: linuxppc-dev@ozlabs.org, linux-pci@atrey.karlin.mff.cuni.cz,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure
Date: Thu, 4 Oct 2007 13:36:29 -0500	[thread overview]
Message-ID: <20071004183629.GH4338@austin.ibm.com> (raw)
In-Reply-To: <20071002012730.GO12049@parisc-linux.org>

On Mon, Oct 01, 2007 at 07:27:30PM -0600, Matthew Wilcox wrote:
> 
> The thing to remember is that sym2 is in transition from being a dual
> BSD/Linux driver to being a purely Linux driver. 

I was wondering about that; couldn't tell if the split in the code
was historical, or being intentionally maintained.

> > My gut instinct is to say "ack", although prudence dictates that 
> > I should test first. Which might take a few days...
> 
> Fine by me.  

I tested the patch, it worked great. It also seemed to recover 
much more quickly -- so quickly, in fact, that I thought something 
had gone wrong.

I reviewed it one more time, it really does look good. A formal
submission and acked by's at earliest convenience would be good. 

--linas

  parent reply	other threads:[~2007-10-04 18:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-20 20:41 [PATCH 1/2]: PCI Error Recovery: Symbios SCSI base support Linas Vepstas
2007-04-20 20:41 ` Linas Vepstas
2007-04-20 20:47 ` [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure Linas Vepstas
2007-04-20 20:47   ` Linas Vepstas
2007-05-09 20:26   ` Linas Vepstas
2007-05-17 19:53     ` Linas Vepstas
2007-09-26 15:02   ` Matthew Wilcox
2007-09-26 15:02     ` Matthew Wilcox
2007-09-27 22:00     ` Linas Vepstas
2007-09-27 22:00       ` Linas Vepstas
2007-09-27 22:10       ` Matthew Wilcox
2007-09-27 22:10         ` Matthew Wilcox
2007-09-27 23:34         ` Linas Vepstas
2007-09-27 23:34           ` Linas Vepstas
2007-10-01 20:12           ` Matthew Wilcox
2007-10-01 20:12             ` Matthew Wilcox
2007-10-01 22:41             ` Linas Vepstas
2007-10-01 22:41               ` Linas Vepstas
2007-10-02  1:27               ` Matthew Wilcox
2007-10-02  1:27                 ` Matthew Wilcox
2007-10-02 21:59                 ` Linas Vepstas
2007-10-02 21:59                   ` Linas Vepstas
2007-10-04 18:36                 ` Linas Vepstas [this message]
2007-10-04 18:36                   ` Linas Vepstas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071004183629.GH4338@austin.ibm.com \
    --to=linas@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.