From: travis@sgi.com
To: Andrew Morton <akpm@linux-foundation.org>,
Paul Jackson <pj@sgi.com>, Tony Luck <tony.luck@intel.com>,
Christoph Lameter <clameter@sgi.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mike Travis <travis@sgi.com>
Subject: [PATCH 1/1] ia64: Convert cpu_sibling_map to a per_cpu data array FIX
Date: Thu, 04 Oct 2007 15:31:42 -0700 [thread overview]
Message-ID: <20071004223141.599952000@sgi.com> (raw)
In-Reply-To: 20071004223141.413776000@sgi.com
[-- Attachment #1: convert-cpu_sibling_map-to-a-per_cpu-data-array-ia64-fix --]
[-- Type: text/plain, Size: 1461 bytes --]
There are two versions of per_cpu_init() for ia64. This patch corrects
the problem that one of the versions did not insert the boot cpu
into the cpu sibling and core maps.
Signed-off-by: Mike Travis <travis@sgi.com>
---
arch/ia64/kernel/setup.c | 8 ++++++++
arch/ia64/mm/contig.c | 6 ------
2 files changed, 8 insertions(+), 6 deletions(-)
--- linux.orig/arch/ia64/kernel/setup.c 2007-10-04 14:38:53.000000000 -0700
+++ linux/arch/ia64/kernel/setup.c 2007-10-04 14:51:46.289055433 -0700
@@ -873,6 +873,14 @@ cpu_init (void)
void *cpu_data;
cpu_data = per_cpu_init();
+ /*
+ * insert boot cpu into sibling and core mapes
+ * (must be done after per_cpu area is setup)
+ */
+ if (smp_processor_id() == 0) {
+ cpu_set(0, per_cpu(cpu_sibling_map, 0));
+ cpu_set(0, cpu_core_map[0]);
+ }
/*
* We set ar.k3 so that assembly code in MCA handler can compute
--- linux.orig/arch/ia64/mm/contig.c 2007-10-04 14:38:53.000000000 -0700
+++ linux/arch/ia64/mm/contig.c 2007-10-04 14:50:12.699513748 -0700
@@ -212,12 +212,6 @@ per_cpu_init (void)
cpu_data += PERCPU_PAGE_SIZE;
per_cpu(local_per_cpu_offset, cpu) = __per_cpu_offset[cpu];
}
- /*
- * cpu_sibling_map is now a per_cpu variable - it needs to
- * be accessed after per_cpu_init() sets up the per_cpu area.
- */
- cpu_set(0, per_cpu(cpu_sibling_map, 0));
- cpu_set(0, cpu_core_map[0]);
}
return __per_cpu_start + __per_cpu_offset[smp_processor_id()];
}
--
WARNING: multiple messages have this Message-ID (diff)
From: travis@sgi.com
To: Andrew Morton <akpm@linux-foundation.org>,
Paul Jackson <pj@sgi.com>, Tony Luck <tony.luck@intel.com>,
Christoph Lameter <clameter@sgi.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mike Travis <travis@sgi.com>
Subject: [PATCH 1/1] ia64: Convert cpu_sibling_map to a per_cpu data array FIX
Date: Thu, 04 Oct 2007 15:31:42 -0700 [thread overview]
Message-ID: <20071004223141.599952000@sgi.com> (raw)
In-Reply-To: 20071004223141.413776000@sgi.com
[-- Attachment #1: convert-cpu_sibling_map-to-a-per_cpu-data-array-ia64-fix --]
[-- Type: text/plain, Size: 1687 bytes --]
There are two versions of per_cpu_init() for ia64. This patch corrects
the problem that one of the versions did not insert the boot cpu
into the cpu sibling and core maps.
Signed-off-by: Mike Travis <travis@sgi.com>
---
arch/ia64/kernel/setup.c | 8 ++++++++
arch/ia64/mm/contig.c | 6 ------
2 files changed, 8 insertions(+), 6 deletions(-)
--- linux.orig/arch/ia64/kernel/setup.c 2007-10-04 14:38:53.000000000 -0700
+++ linux/arch/ia64/kernel/setup.c 2007-10-04 14:51:46.289055433 -0700
@@ -873,6 +873,14 @@ cpu_init (void)
void *cpu_data;
cpu_data = per_cpu_init();
+ /*
+ * insert boot cpu into sibling and core mapes
+ * (must be done after per_cpu area is setup)
+ */
+ if (smp_processor_id() == 0) {
+ cpu_set(0, per_cpu(cpu_sibling_map, 0));
+ cpu_set(0, cpu_core_map[0]);
+ }
/*
* We set ar.k3 so that assembly code in MCA handler can compute
--- linux.orig/arch/ia64/mm/contig.c 2007-10-04 14:38:53.000000000 -0700
+++ linux/arch/ia64/mm/contig.c 2007-10-04 14:50:12.699513748 -0700
@@ -212,12 +212,6 @@ per_cpu_init (void)
cpu_data += PERCPU_PAGE_SIZE;
per_cpu(local_per_cpu_offset, cpu) = __per_cpu_offset[cpu];
}
- /*
- * cpu_sibling_map is now a per_cpu variable - it needs to
- * be accessed after per_cpu_init() sets up the per_cpu area.
- */
- cpu_set(0, per_cpu(cpu_sibling_map, 0));
- cpu_set(0, cpu_core_map[0]);
}
return __per_cpu_start + __per_cpu_offset[smp_processor_id()];
}
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-10-04 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 22:31 [PATCH 0/1] ia64: Convert cpu_sibling_map to a per_cpu data array FIX travis
2007-10-04 22:31 ` travis
2007-10-04 22:31 ` travis [this message]
2007-10-04 22:31 ` [PATCH 1/1] " travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004223141.599952000@sgi.com \
--to=travis@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pj@sgi.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.