From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Subject: [PATCH] do not require that device is a partition
Date: Fri, 5 Oct 2007 11:59:48 +0200 [thread overview]
Message-ID: <20071005095948.GA27825@thorin> (raw)
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
Hi!
Devices where the filesystem is in whole disk are common nowadays [1]; I
don't think it's a good idea to require that a filesystem is in a partition
in order to access it.
See attached patch. Any comments?
[1] for example, debian provides usb images of the debian-installer with a
fat filesystem and no partitions:
http://people.debian.org/~joeyh/d-i/images/daily/hd-media/boot.img.gz
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
[-- Attachment #2: disk_fs.diff --]
[-- Type: text/x-diff, Size: 580 bytes --]
2007-10-05 Robert Millan <rmh@aybabtu.com>
* normal/misc.c (grub_normal_print_device_info): Do not require that
device is a partition.
diff -ur grub2/normal/misc.c grub2.disk_fs/normal/misc.c
--- grub2/normal/misc.c 2007-07-22 01:32:29.000000000 +0200
+++ grub2.disk_fs/normal/misc.c 2007-10-05 11:55:29.000000000 +0200
@@ -40,7 +40,7 @@
dev = grub_device_open (name);
if (! dev)
grub_printf ("Filesystem cannot be accessed");
- else if (! dev->disk || ! dev->disk->has_partitions || dev->disk->partition)
+ else
{
char *label;
grub_fs_t fs;
next reply other threads:[~2007-10-05 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-05 9:59 Robert Millan [this message]
2007-10-05 12:30 ` [PATCH] do not require that device is a partition Robert Millan
2007-10-06 20:16 ` Robert Millan
2007-10-14 15:49 ` Robert Millan
2007-10-15 7:59 ` Marco Gerards
2007-10-15 11:00 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071005095948.GA27825@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.