From: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-scsi@vger.kernel.org, matthew@wil.cx, willy@linux.intel.com
Subject: Re: [PATCH 21/21] advansys: Changes to work on parisc
Date: Fri, 5 Oct 2007 12:03:55 -0700 [thread overview]
Message-ID: <20071005120355.8986ca0a.akpm@linux-foundation.org> (raw)
In-Reply-To: <11913765432770-git-send-email-matthew@wil.cx>
On Tue, 2 Oct 2007 21:55:42 -0400
Matthew Wilcox <matthew@wil.cx> wrote:
> @@ -13428,9 +13428,9 @@ static int __devinit advansys_board_found(struct Scsi_Host *shost,
> boardp->ioremap_addr = ioremap(pci_resource_start(pdev, 1),
> boardp->asc_n_io_port);
> if (!boardp->ioremap_addr) {
> - shost_printk(KERN_ERR, shost, "ioremap(%x, %d) "
> + shost_printk(KERN_ERR, shost, "ioremap(%lx, %d) "
> "returned NULL\n",
> - pci_resource_start(pdev, 1),
> + (long)pci_resource_start(pdev, 1),
> boardp->asc_n_io_port);
This isn't right. resource_size_t can be 64-bit so should be cast to
unsigned long long and printed with %llx.
If it is known that this driver will never encounter a 64-bit address here
then this optimisation should be accompanied by a comment at every place
where it is employed so that people do not copy the wrong code into other
drivers.
next prev parent reply other threads:[~2007-10-05 19:04 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 1:55 [PATCH 01/21] advansys: Eliminate prototypes Matthew Wilcox
2007-10-03 1:55 ` [PATCH 02/21] advansys: Remove array of scsi targets Matthew Wilcox
2007-10-03 2:19 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 03/21] advansys: Restructure asc_execute_scsi_cmnd() Matthew Wilcox
2007-10-03 2:17 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 04/21] advansys: Fix simultaneous calls to ->queuecommand Matthew Wilcox
2007-10-08 10:07 ` Boaz Harrosh
2007-10-09 13:27 ` Matthew Wilcox
2007-10-03 1:55 ` [PATCH 05/21] advansys: Improve reset handler Matthew Wilcox
2007-10-03 1:55 ` [PATCH 06/21] advansys: Remove ASC_SELECT_QUEUE_DEPTHS Matthew Wilcox
2007-10-03 2:17 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 07/21] advansys: Remove ASC_WIDE_BOARD predicate Matthew Wilcox
2007-10-03 1:55 ` [PATCH 08/21] advansys: Sort out irq number mess Matthew Wilcox
2007-10-03 1:55 ` [PATCH 09/21] advansys: Merge ASC_IERR definitions Matthew Wilcox
2007-10-03 1:55 ` [PATCH 10/21] advansys: Remove asc_board_t typedef and ASC_BOARDP macro Matthew Wilcox
2007-10-03 2:02 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 11/21] advansys: Remove library version & serial numbers Matthew Wilcox
2007-10-03 2:14 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 12/21] advansys: Sort out debug macros Matthew Wilcox
2007-10-03 2:02 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 13/21] advansys: Remove private lock Matthew Wilcox
2007-10-03 2:09 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 14/21] advansys: Get rid of board index number Matthew Wilcox
2007-10-03 2:04 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 15/21] advansys: Make sdtr_period_tbl a pointer Matthew Wilcox
2007-10-03 1:55 ` [PATCH 16/21] advansys: Move a couple of fields from struct board to struct adv_dvc Matthew Wilcox
2007-10-03 1:55 ` [PATCH 17/21] advansys: Remove DvcGetPhyAddr Matthew Wilcox
2007-10-03 2:13 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 18/21] advansys: convert to use the data buffer accessors Matthew Wilcox
2007-10-03 1:55 ` [PATCH 19/21] advansys: Remove a couple of uses of bus_to_virt Matthew Wilcox
2007-10-03 2:13 ` Jeff Garzik
2007-10-03 12:37 ` Matthew Wilcox
2007-10-03 14:28 ` Jeff Garzik
2007-10-03 14:34 ` Matthew Wilcox
2007-10-03 14:46 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 20/21] advansys: Use dma mapping for overrun buffer Matthew Wilcox
2007-10-03 2:11 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 21/21] advansys: Changes to work on parisc Matthew Wilcox
2007-10-03 2:00 ` Jeff Garzik
2007-10-03 2:15 ` Matthew Wilcox
2007-10-03 2:28 ` Jeff Garzik
2007-10-03 3:00 ` Matthew Wilcox
2007-10-03 3:15 ` Jeff Garzik
2007-10-03 8:06 ` Christoph Hellwig
2007-10-03 8:05 ` Christoph Hellwig
2007-10-03 14:45 ` Jeff Garzik
2007-10-05 19:03 ` Andrew Morton [this message]
2007-10-05 19:34 ` Matthew Wilcox
2007-10-05 20:00 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071005120355.8986ca0a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.