From: Jeff Garzik <jeff@garzik.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org, Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH 21/21] advansys: Changes to work on parisc
Date: Tue, 02 Oct 2007 23:15:01 -0400 [thread overview]
Message-ID: <47030935.5020000@garzik.org> (raw)
In-Reply-To: <20071003030039.GE12049@parisc-linux.org>
Matthew Wilcox wrote:
> On Tue, Oct 02, 2007 at 10:28:29PM -0400, Jeff Garzik wrote:
>> Incorrect. That is highly platform specific, with many using unsigned
>> long, since the [non-x86] platform is generally pointing to a special
>> memory region rather than directly using an x86-like instruction.
>>
>> unsigned long is the portable size to use, because it is guaranteed to
>> work on all platforms.
>>
>> unsigned int means you exclude powerpc[64], alpha, sparc64, sh, ...
>> it's not portable, unlike unsigned long.
>
> I don't think that's true. I asked a powerpc64 person about it the
> other day, and he said they don't use anything beyond the lower 32 bits.
>
> If people are really supposed to use unsigned long, it would make sense
> to get the i386 macros changed, since they are canonical.
You're pushing against over a decade-long practice and moving into
NAK-land... This is the way portable drivers have always been written.
If you want to go against the grain, first change the architectures to
not use unsigned long. Until such time... you know what to do :)
Jeff
next prev parent reply other threads:[~2007-10-03 3:15 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 1:55 [PATCH 01/21] advansys: Eliminate prototypes Matthew Wilcox
2007-10-03 1:55 ` [PATCH 02/21] advansys: Remove array of scsi targets Matthew Wilcox
2007-10-03 2:19 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 03/21] advansys: Restructure asc_execute_scsi_cmnd() Matthew Wilcox
2007-10-03 2:17 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 04/21] advansys: Fix simultaneous calls to ->queuecommand Matthew Wilcox
2007-10-08 10:07 ` Boaz Harrosh
2007-10-09 13:27 ` Matthew Wilcox
2007-10-03 1:55 ` [PATCH 05/21] advansys: Improve reset handler Matthew Wilcox
2007-10-03 1:55 ` [PATCH 06/21] advansys: Remove ASC_SELECT_QUEUE_DEPTHS Matthew Wilcox
2007-10-03 2:17 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 07/21] advansys: Remove ASC_WIDE_BOARD predicate Matthew Wilcox
2007-10-03 1:55 ` [PATCH 08/21] advansys: Sort out irq number mess Matthew Wilcox
2007-10-03 1:55 ` [PATCH 09/21] advansys: Merge ASC_IERR definitions Matthew Wilcox
2007-10-03 1:55 ` [PATCH 10/21] advansys: Remove asc_board_t typedef and ASC_BOARDP macro Matthew Wilcox
2007-10-03 2:02 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 11/21] advansys: Remove library version & serial numbers Matthew Wilcox
2007-10-03 2:14 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 12/21] advansys: Sort out debug macros Matthew Wilcox
2007-10-03 2:02 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 13/21] advansys: Remove private lock Matthew Wilcox
2007-10-03 2:09 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 14/21] advansys: Get rid of board index number Matthew Wilcox
2007-10-03 2:04 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 15/21] advansys: Make sdtr_period_tbl a pointer Matthew Wilcox
2007-10-03 1:55 ` [PATCH 16/21] advansys: Move a couple of fields from struct board to struct adv_dvc Matthew Wilcox
2007-10-03 1:55 ` [PATCH 17/21] advansys: Remove DvcGetPhyAddr Matthew Wilcox
2007-10-03 2:13 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 18/21] advansys: convert to use the data buffer accessors Matthew Wilcox
2007-10-03 1:55 ` [PATCH 19/21] advansys: Remove a couple of uses of bus_to_virt Matthew Wilcox
2007-10-03 2:13 ` Jeff Garzik
2007-10-03 12:37 ` Matthew Wilcox
2007-10-03 14:28 ` Jeff Garzik
2007-10-03 14:34 ` Matthew Wilcox
2007-10-03 14:46 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 20/21] advansys: Use dma mapping for overrun buffer Matthew Wilcox
2007-10-03 2:11 ` Jeff Garzik
2007-10-03 1:55 ` [PATCH 21/21] advansys: Changes to work on parisc Matthew Wilcox
2007-10-03 2:00 ` Jeff Garzik
2007-10-03 2:15 ` Matthew Wilcox
2007-10-03 2:28 ` Jeff Garzik
2007-10-03 3:00 ` Matthew Wilcox
2007-10-03 3:15 ` Jeff Garzik [this message]
2007-10-03 8:06 ` Christoph Hellwig
2007-10-03 8:05 ` Christoph Hellwig
2007-10-03 14:45 ` Jeff Garzik
2007-10-05 19:03 ` Andrew Morton
2007-10-05 19:34 ` Matthew Wilcox
2007-10-05 20:00 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47030935.5020000@garzik.org \
--to=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.