* [PATCH 3/5] cleanup 3rd argument in netlink_sendskb
@ 2007-10-05 14:46 Denis V. Lunev
2007-10-11 4:14 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Denis V. Lunev @ 2007-10-05 14:46 UTC (permalink / raw)
To: davem; +Cc: netdev, kuznet, devel, containers
netlink_sendskb does not use third argument. Clean it and save a couple of
bytes.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Acked-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
--- ./include/linux/netlink.h.nlk5 2007-08-26 19:30:37.000000000 +0400
+++ ./include/linux/netlink.h 2007-10-02 11:53:09.000000000 +0400
@@ -194,7 +194,7 @@ struct sock *netlink_getsockbyfilp(struc
int netlink_attachskb(struct sock *sk, struct sk_buff *skb, int nonblock,
long timeo, struct sock *ssk);
void netlink_detachskb(struct sock *sk, struct sk_buff *skb);
-int netlink_sendskb(struct sock *sk, struct sk_buff *skb, int protocol);
+int netlink_sendskb(struct sock *sk, struct sk_buff *skb);
/*
* skb should fit one page. This choice is good for headerless malloc.
--- ./ipc/mqueue.c.nlk5 2007-08-26 19:30:37.000000000 +0400
+++ ./ipc/mqueue.c 2007-10-02 11:52:27.000000000 +0400
@@ -521,8 +521,7 @@ static void __do_notify(struct mqueue_in
break;
case SIGEV_THREAD:
set_cookie(info->notify_cookie, NOTIFY_WOKENUP);
- netlink_sendskb(info->notify_sock,
- info->notify_cookie, 0);
+ netlink_sendskb(info->notify_sock, info->notify_cookie);
break;
}
/* after notification unregisters process */
@@ -568,7 +567,7 @@ static void remove_notification(struct m
if (info->notify_owner != NULL &&
info->notify.sigev_notify == SIGEV_THREAD) {
set_cookie(info->notify_cookie, NOTIFY_REMOVED);
- netlink_sendskb(info->notify_sock, info->notify_cookie, 0);
+ netlink_sendskb(info->notify_sock, info->notify_cookie);
}
put_pid(info->notify_owner);
info->notify_owner = NULL;
--- ./net/netlink/af_netlink.c.nlk5 2007-10-02 11:43:09.000000000 +0400
+++ ./net/netlink/af_netlink.c 2007-10-02 11:50:19.000000000 +0400
@@ -796,7 +796,7 @@ int netlink_attachskb(struct sock *sk, s
return 0;
}
-int netlink_sendskb(struct sock *sk, struct sk_buff *skb, int protocol)
+int netlink_sendskb(struct sock *sk, struct sk_buff *skb)
{
int len = skb->len;
@@ -858,7 +858,7 @@ retry:
if (err)
return err;
- return netlink_sendskb(sk, skb, ssk->sk_protocol);
+ return netlink_sendskb(sk, skb);
}
int netlink_has_listeners(struct sock *sk, unsigned int group)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3/5] cleanup 3rd argument in netlink_sendskb
2007-10-05 14:46 [PATCH 3/5] cleanup 3rd argument in netlink_sendskb Denis V. Lunev
@ 2007-10-11 4:14 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-10-11 4:14 UTC (permalink / raw)
To: den; +Cc: netdev, kuznet, devel, containers
From: "Denis V. Lunev" <den@openvz.org>
Date: Fri, 5 Oct 2007 18:46:23 +0400
> netlink_sendskb does not use third argument. Clean it and save a couple of
> bytes.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Acked-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-11 4:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-05 14:46 [PATCH 3/5] cleanup 3rd argument in netlink_sendskb Denis V. Lunev
2007-10-11 4:14 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.