All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jordan Crouse" <jordan.crouse@amd.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Martin K. Petersen" <mkp@mkp.net>, Jeff Garzik <jeff@garzik.org>,
	linux-ide@vger.kernel.org
Subject: Re: pata_cs5536: ATA driver for Geode companion chip (MSR)
Date: Fri, 5 Oct 2007 08:53:56 -0600	[thread overview]
Message-ID: <20071005145356.GC32104@cosmic.amd.com> (raw)
In-Reply-To: <20071005130127.6165e2e3@the-village.bc.nu>

On 05/10/07 13:01 +0100, Alan Cox wrote:
> > pata_cs5536.c relies on Geode Machine Specific Registers to configure
> > the ATA function and uses the correct PIO timings for the chip.
> 
> Any reason for not supporting both methods ? Though I guess as you say
> msr is sufficient.
> 
> 
> > +#ifndef CONFIG_PATA_CS5536	/* Temporary */
> 
> 	!defined(FOO) && ! defined(FOO_MODULE)
> 
> otherwise ACK

ACK as well, but I put a call out on the Geode list for testing - I want
to make sure that we get some time on different platforms with different
BIOSes to make sure it is solid.

Jordan

-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.



  reply	other threads:[~2007-10-05 14:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-03 23:30 pata_cs5536: ATA driver for Geode companion chip Jordan Crouse
2007-10-04  3:29 ` Martin K. Petersen
2007-10-04 12:04   ` Alan Cox
2007-10-04 15:58   ` Alan Cox
2007-10-04 16:08     ` Jordan Crouse
2007-10-04 16:22       ` Alan Cox
2007-10-04 17:00         ` Martin K. Petersen
2007-10-05  6:05       ` Martin K. Petersen
2007-10-05  6:06       ` [PATCH] pata_cs5536: ATA driver for Geode companion chip (PCI) Martin K. Petersen
2007-10-05  6:07       ` [PATCH] pata_cs5536: ATA driver for Geode companion chip (MSR) Martin K. Petersen
2007-10-05 12:01         ` Alan Cox
2007-10-05 14:53           ` Jordan Crouse [this message]
2007-10-05 19:00           ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071005145356.GC32104@cosmic.amd.com \
    --to=jordan.crouse@amd.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=mkp@mkp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.