Re: [PATCH] pata_cs5536: ATA driver for Geode companion chip (MSR)

["Martin K. Petersen" <mkp@mkp.net>]

>>>>> "Alan" == Alan Cox <alan@lxorguk.ukuu.org.uk> writes:

>> pata_cs5536.c relies on Geode Machine Specific Registers to
>> configure the ATA function and uses the correct PIO timings for the
>> chip.

Alan> Any reason for not supporting both methods ? Though I guess as
Alan> you say msr is sufficient.

Given that we don't have a good way to detect failure other than
libata failing to set PIO timings, I think it's going to be
unnecessary complexity.  As I wrote, the BIOS versions all behaved
differently (in a previous rev. the written value would look ok in the
PCI config register but not trickle back to MSR space).

In any case the friendly firmware fairy left me a working BIOS this
morning.  Byte-aligned PCI config space accesses do the right thing.
So as far as I'm concerned the case has been solv-ed.  I'm now
officially agnostic.

Jordan: You're probably dealing with issues like this more frequently
than we are.  What's your preference for pata_cs5536.c?  MSR or PCI?

-- 
Martin K. Petersen      http://mkp.net/