From: Andrew Morton <akpm@linux-foundation.org>
To: Paul Jackson <pj@sgi.com>
Cc: nickpiggin@yahoo.com.au, randy.dunlap@oracle.com,
menage@google.com, linux-kernel@vger.kernel.org, dino@in.ibm.com,
pj@sgi.com, cpw@sgi.com, mingo@elte.hu
Subject: Re: [PATCH] cpuset and sched domains: sched_load_balance flag fixes
Date: Fri, 5 Oct 2007 16:13:05 -0700 [thread overview]
Message-ID: <20071005161305.af27f452.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071003114401.32194.73464.sendpatchset@jackhammer.engr.sgi.com>
On Wed, 03 Oct 2007 04:44:01 -0700
Paul Jackson <pj@sgi.com> wrote:
> From: Paul Jackson <pj@sgi.com>
>
> Thanks to Randy Dunlap for the review that caught
> some of the following.
>
> Some bug fixes and coding style fixes:
> 1) only one statement per line, please.
> 2) don't need to guard kfree() calls with a NULL check
> 3) use kfifo_free, not kfree, if it came from kfifo_alloc
> 4) a pair of curly brackets got lost along the way
> 5) missing .read, .write callbacks for sched_load_balance
>
> Without (3), one kfifo buffer memory was leaked each time
> one rebuilt scheduler domains
>
> Without (4), the current task was summarily killed each
> time one tried to rebuild scheduler domains
>
> Without (5), every read or write system call on a per-cpuset
> special file 'sched_load_balance' failed, EINVAL.
>
> Signed-off-by: Paul Jackson <pj@sgi.com>
>
> ---
>
> Andrew,
>
> These fixes go right after the patch they fix:
> [PATCH] cpuset and sched domains: sched_load_balance flag
I'm getting 100% rejects from this - probably whatever patch it is
patching got lost or unrecognisably mangled.
next prev parent reply other threads:[~2007-10-05 23:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 11:44 [PATCH] cpuset and sched domains: sched_load_balance flag fixes Paul Jackson
2007-10-05 23:13 ` Andrew Morton [this message]
2007-10-05 23:39 ` Paul Jackson
2007-10-06 5:53 ` Ingo Molnar
2007-10-06 6:01 ` Paul Jackson
2007-10-06 6:21 ` Ingo Molnar
2007-10-06 6:28 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071005161305.af27f452.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cpw@sgi.com \
--cc=dino@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=pj@sgi.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.