From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: legoater@free.fr, netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] [TCP]: Fix two off-by-one errors in fackets_out adjusting logic
Date: Sun, 07 Oct 2007 23:36:58 -0700 (PDT) [thread overview]
Message-ID: <20071007.233658.25210806.davem@davemloft.net> (raw)
In-Reply-To: <11914092183725-git-send-email-ilpo.jarvinen@helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Wed, 3 Oct 2007 14:00:16 +0300
> 1) Passing wrong skb to tcp_adjust_fackets_out could corrupt
> fastpath_cnt_hint as tcp_skb_pcount(next_skb) is not included
> to it if hint points exactly to the next_skb (it's lagging
> behind, see sacktag).
>
> 2) When fastpath_skb_hint is put backwards to avoid dangling
> skb reference, the skb's pcount must also be removed from count
> (not included like above).
>
> Reported by Cedric Le Goater <legoater@free.fr>
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Applied, thanks Ilpo.
next prev parent reply other threads:[~2007-10-08 6:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 11:00 [PATCH net-2.6.24 0/3]: More TCP fixes Ilpo Järvinen
2007-10-03 11:00 ` [PATCH 1/3] [TCP]: Fix two off-by-one errors in fackets_out adjusting logic Ilpo Järvinen
2007-10-03 11:00 ` [PATCH 2/3] [TCP]: Comment fastpath_cnt_hint off-by-one trap Ilpo Järvinen
2007-10-03 11:00 ` [PATCH 3/3] [TCP]: "Annotate" another fackets_out state reset Ilpo Järvinen
2007-10-08 6:38 ` David Miller
2007-10-08 6:37 ` [PATCH 2/3] [TCP]: Comment fastpath_cnt_hint off-by-one trap David Miller
2007-10-08 6:36 ` David Miller [this message]
2007-10-03 11:58 ` [PATCH net-2.6.24 0/3]: More TCP fixes Cedric Le Goater
2007-10-03 12:34 ` Ilpo Järvinen
2007-10-03 12:48 ` Cedric Le Goater
2007-10-03 13:19 ` Ilpo Järvinen
2007-10-03 14:05 ` Cedric Le Goater
2007-10-03 14:22 ` Ilpo Järvinen
2007-10-03 14:58 ` Cedric Le Goater
2007-10-03 14:59 ` Cedric Le Goater
2007-10-03 15:12 ` Cedric Le Goater
2007-10-04 10:13 ` Ilpo Järvinen
2007-10-04 14:53 ` Cedric Le Goater
2007-10-04 20:20 ` [PATCH net-2.6.24] [TCP]: Fix fastpath_cnt_hint when GSO skb is partially ACKed Ilpo Järvinen
2007-10-08 6:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071007.233658.25210806.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=legoater@free.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.