All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cedric Le Goater <legoater@free.fr>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6.24 0/3]: More TCP fixes
Date: Wed, 03 Oct 2007 13:58:12 +0200	[thread overview]
Message-ID: <470383D4.9060307@free.fr> (raw)
In-Reply-To: <1191409218982-git-send-email-ilpo.jarvinen@helsinki.fi>

Hello Ilpo !

Ilpo Järvinen wrote:
> Hi Dave,
> 
> Sacktag fastpath_cnt_hint seems to be very tricky to get right...
> I suppose this one fixes Cedric's case. I cannot say for sure    
> until there is something more definite indication of
> tcp_retrans_try_collapse origin than what the simple late WARN_ON
> gave for us. ...Especially since it's non-trivial to have skb
> hint "correctly" positioned in the write_queue while still ending
> up calling that function. However, considering how difficult it
> seems to be for Cedric to reproduce, it might well be this one.
> 
> In addition, I noticed another reset which wasn't previously   
> converted to WARN_ON, so doing that now. Boot + simple xfer
> tested. Please apply to net-2.6.24.

I'm dropping the previous patches you sent me and switching to this patchset. 
right ?

Thanks,

C.

  parent reply	other threads:[~2007-10-03 12:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-03 11:00 [PATCH net-2.6.24 0/3]: More TCP fixes Ilpo Järvinen
2007-10-03 11:00 ` [PATCH 1/3] [TCP]: Fix two off-by-one errors in fackets_out adjusting logic Ilpo Järvinen
2007-10-03 11:00   ` [PATCH 2/3] [TCP]: Comment fastpath_cnt_hint off-by-one trap Ilpo Järvinen
2007-10-03 11:00     ` [PATCH 3/3] [TCP]: "Annotate" another fackets_out state reset Ilpo Järvinen
2007-10-08  6:38       ` David Miller
2007-10-08  6:37     ` [PATCH 2/3] [TCP]: Comment fastpath_cnt_hint off-by-one trap David Miller
2007-10-08  6:36   ` [PATCH 1/3] [TCP]: Fix two off-by-one errors in fackets_out adjusting logic David Miller
2007-10-03 11:58 ` Cedric Le Goater [this message]
2007-10-03 12:34   ` [PATCH net-2.6.24 0/3]: More TCP fixes Ilpo Järvinen
2007-10-03 12:48     ` Cedric Le Goater
2007-10-03 13:19       ` Ilpo Järvinen
2007-10-03 14:05         ` Cedric Le Goater
2007-10-03 14:22           ` Ilpo Järvinen
2007-10-03 14:58             ` Cedric Le Goater
2007-10-03 14:59               ` Cedric Le Goater
2007-10-03 15:12               ` Cedric Le Goater
2007-10-04 10:13                 ` Ilpo Järvinen
2007-10-04 14:53                   ` Cedric Le Goater
2007-10-04 20:20                     ` [PATCH net-2.6.24] [TCP]: Fix fastpath_cnt_hint when GSO skb is partially ACKed Ilpo Järvinen
2007-10-08  6:39                       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=470383D4.9060307@free.fr \
    --to=legoater@free.fr \
    --cc=davem@davemloft.net \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.