All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] [PATCH] hwmon/lm87: Disable VID when it should be
@ 2007-10-08 20:48 Jean Delvare
  2007-10-09  1:24 ` Mark M. Hoffman
  0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2007-10-08 20:48 UTC (permalink / raw)
  To: lm-sensors

A stupid bit shifting bug caused the VID value to be always exported
even when the hardware is configured for something different.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
 drivers/hwmon/lm87.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.23-rc9.orig/drivers/hwmon/lm87.c	2007-10-08 21:26:20.000000000 +0200
+++ linux-2.6.23-rc9/drivers/hwmon/lm87.c	2007-10-08 22:14:50.000000000 +0200
@@ -146,7 +146,7 @@ static u8 LM87_REG_TEMP_LOW[3] = { 0x3A,
 #define CHAN_NO_FAN(nr)		(1 << (nr))
 #define CHAN_TEMP3		(1 << 2)
 #define CHAN_VCC_5V		(1 << 3)
-#define CHAN_NO_VID		(1 << 8)
+#define CHAN_NO_VID		(1 << 7)
 
 /*
  * Functions declaration


-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [lm-sensors] [PATCH] hwmon/lm87: Disable VID when it should be
  2007-10-08 20:48 [lm-sensors] [PATCH] hwmon/lm87: Disable VID when it should be Jean Delvare
@ 2007-10-09  1:24 ` Mark M. Hoffman
  0 siblings, 0 replies; 2+ messages in thread
From: Mark M. Hoffman @ 2007-10-09  1:24 UTC (permalink / raw)
  To: lm-sensors

Hi:

* Jean Delvare <khali@linux-fr.org> [2007-10-08 22:48:10 +0200]:
> A stupid bit shifting bug caused the VID value to be always exported
> even when the hardware is configured for something different.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
>  drivers/hwmon/lm87.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to hwmon-2.6.git/testing, thanks.

-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-10-09  1:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-08 20:48 [lm-sensors] [PATCH] hwmon/lm87: Disable VID when it should be Jean Delvare
2007-10-09  1:24 ` Mark M. Hoffman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.